Re: [cdt-dev] Committers, please check the URL you use

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

The other option is adding a server side hook to disable pushes to refs/for/

https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks

That could be rolled out across all git repos at Eclipse for every
project's benefit.

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 11 April 2016 at 20:28, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
> Do we really need to do that or is everyone good now that they're thinking
> about it? We really don't have that many active committers doing pushes.
>
> Doug.
>
> On Mon, Apr 11, 2016 at 3:20 PM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>
> wrote:
>>
>> Denis has the vision to retire pure git:
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=452549#c1
>> but it hasn't happened yet.
>>
>> Getting rid of it just for CDT may be possible.
>> I was originally concerned about a possible firewall issue for some, but
>> when
>> I think about it, if such an issue was present, then those committers
>> could never
>> push to Gerrit, I think.  So they really must get that issue fixed on
>> their side anyway.
>>
>> Any concerns about asking the webmaster to retire the direct push URL?
>>
>> ________________________________________
>> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf
>> of Marc-André Laperle [marc-andre.laperle@xxxxxxxxxxxx]
>> Sent: April 11, 2016 12:44 PM
>> To: CDT General developers list.
>> Subject: Re: [cdt-dev] Committers, please check the URL you use
>>
>> Can the one without the port be disabled? AFAIK, it's still possible to
>> push directly with the 29418 one but the "refs/for/master" issue can't
>> happen.
>> ________________________________________
>> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf
>> of Marc Khouzam [marc.khouzam@xxxxxxxxxxxx]
>> Sent: Monday, 11 April 2016 11:40 AM
>> To: CDT DEV (cdt-dev@xxxxxxxxxxx)
>> Subject: [cdt-dev] Committers, please check the URL you use
>>
>> Hello,
>>
>> committers should be using the following URL to interact with the CDT
>> repo:
>>
>>     ssh://<commiterId>@git.eclipse.org:29418/cdt/org.eclipse.cdt.git
>>
>> It is possible that this URL is being blocked by your firewall, which may
>> explain why you are not using it, but I would ask you to check to be sure.
>> You can check the URL you are using through EGit or by running
>>   git remote -v
>>
>> I've updated the wiki to emphasize the proper URL:
>> https://wiki.eclipse.org/CDT/git#Source_Repositories
>>
>> For those wondering, the above URL does not force you to push everything
>> to a review.
>> Although going through a Gerrit review is always recommended, even if just
>> to wait
>> for the Verify build to pass, you can still push directly to the repo by
>> using that same URL.
>> If you push to 'refs/for/master' it will create a review for the master
>> branch.
>> If you push to 'refs/heads/master' it will commit directly on master.
>>
>> Why is it important to use that URL?  It will prevent an erroneous commit
>> from creating
>> a branch "refs/for/master" which would then prevent any new Gerrit reviews
>> from being created.
>> Please see details at:
>> https://dev.eclipse.org/mhonarc/lists/cdt-dev/msg30545.html
>>
>> Thanks.
>>
>> Marc
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev