Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Toggel CDT checking with

Hi Alena,

I will rediscuss this requirement with the stakeholders if they really want to pollute source code with Codan lines. Your argument is valid, although this solution is used in a lot beautifiers/QA tools. Even Eclipse Java formatter can be turn on/off through tags in source code  (// @formatter:[on|off]). If I cannot persuade the stakeholders, it might be a solution if we can obtain the patch where this bug was implemented, so we can use it in our own Codan checker. Can you give instructions how to incorperate the patch in our plugin?

Dennis Gallas


Van: Alena Laskavaia <laskava@xxxxxxxxx>
Aan: Dennis Gallas <dennis.gallas@xxxxxxxx>
Cc: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
Verzonden: 5-1-2016 15:19
Onderwerp: Re: Toggel CDT checking with

There are suppression rules per file/per error type. Some checkers support suppression by argument.
It is not hard to add it just a bad idea in general and bad requirement to enforce suppression by comment in the code.
If you want to contribute this solution we can continue discussion on this bug.

On Tue, Jan 5, 2016 at 8:11 AM, Dennis Gallas <dennis.gallas@xxxxxxxx> wrote:
Hi Alena,

Thanks for your quick response. It is a requirement for the project. If it can be solved in another way, I can also accept it. This is the requirement:

"It shall be possible for the user to suppress rules. The suppression must be scope based (inside operation / file). .... Suppression of Code checks must be possible per line using C or C++ comment style...."

The "comment style" can be ignored, if there is another way to indicate which line(s) of code to suppress.

Best regards,

Dennis Gallas

Van: Alena Laskavaia <laskava@xxxxxxxxx>
Aan: Dennis Gallas <dennis.gallas@xxxxxxxx>
Cc: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
Verzonden: 5-1-2016 13:59
Onderwerp: Re: Toggel CDT checking with

I don't think we have this now. I am generally against the solutions which pollute the code with tool specific comments.
There are few other ways to go around it - is this a specific error you talking about? Is it false positive?

On Tue, Jan 5, 2016 at 3:21 AM, Dennis Gallas <dennis.gallas@xxxxxxxx> wrote:
Hi,

Is there a way to turn Codan on/off for specific lines? I read the bug report "https://bugs.eclipse.org/bugs/show_bug.cgi?id=383576" about a possible solution. The solution is to toggel Codan checker with comment lines "// codan:[on|off]". However, I don't think this code ever got delivered to the mainline. Is there a plan to ever get this feature in?

Regards,

Dennis Gallas







Back to the top