Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Incomplete QML Analyzer button in the main toolbar

> If you aren’t working it, don’t press it.

It's not the pressing it that's annoying, it is the extra clutter in my toolbar.
It's also the fact that when I saw it I had to figure out where it came from,
to make sure it was not a bug that should be reported before it gets released.
And it's because other committers might be affected similarly and wasting time.

If that button is meant as a temporary helper, why is it in master?

If it is a question of sharing code between people then I don't see why pulling
from the master branch is any easier than pulling from another branch that
contains the work not ready for master.  If people don't want to keep
work-in-progress in a Gerrit review, then a development branch is the best way to
go I think.  That's the approach Andrew took for the Scanner Discovery work and
I believe it went smoothly.

Thanks

Marc


From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Doug Schaefer [dschaefer@xxxxxxx]
Sent: December 3, 2015 4:12 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] Incomplete QML Analyzer button in the main toolbar

That button is complete. It's there to help us for the next couple of weeks or so while developing the QML Analyzer which is written in _javascript_. If you aren’t working it, don’t press it.

Doug.


From: <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Thursday, December 3, 2015 at 3:48 PM
To: "CDT DEV (cdt-dev@xxxxxxxxxxx)" <cdt-dev@xxxxxxxxxxx>
Subject: [cdt-dev] Incomplete QML Analyzer button in the main toolbar

Hi Doug,

I noticed a new button in the main toolbar to "Reload QML Analyzer".
Its icon is 'sample.gif' which is a generic eclipse icon.
When I press it if fails with an error.

Since committers use target definitions and therefore can load all cdt plugins all the time, we should be careful what we add to the global UI as it will be visible to every committer quickly.  I'm assuming this is a work in progress since the icon is not the final one.  Unless you want all committers to have access to this right away, I would recommend not committing such changes until they are complete.

Thanks

Marc






Back to the top