| Re: [cdt-dev] adding a toolchain with common options to tools (Warren Paul) |
|
It’s been quite a while since I looked at that code, but what I remember is there are actually two states of the option. The getOptionById I believe gets you the working copy of the option. So if you have the build settings UI open, that’s the current
value in the UI, whereas getOptionBySuperTypeId gets you the persisted value. When the UI is not open I think you just get the persisted option. Basically when the id ends in .some_number it’s the possibly dirty working copy.
I also remember that changing these toolchain-wide options does not dirty the configuration by default. Since you probably want to rebuild the configuration when changing such options, you need to handle that yourself. It’s pretty easy though. Just
specify a valueHandler for each option. Your valueHandler can extend ManagedOptionValueHandler and override handleValue. Something like this:
@Override public boolean handleValue(IBuildObject configuration, IHoldsOptions holder, IOption option, String extraArgument, int event) {
if (event == IManagedOptionValueHandler.EVENT_APPLY && ((Option) option).isDirty()) { IConfiguration config = ((IToolChain)holder).getParent(); if (config != null) { config.setRebuildState(true); } return true; } return false; }
From: Ashutosh <ashutoshpal2006@xxxxxxxxx>
Reply-To: "CDT list." <cdt-dev@xxxxxxxxxxx> Date: Friday, September 18, 2015 at 1:53 AM To: "CDT list." <cdt-dev@xxxxxxxxxxx> Subject: Re: [cdt-dev] adding a toolchain with common options to tools (Warren Paul) Hi Warren,
Thanks for your response.public String generateCommand(IOption option, IVariableSubstitutor macroSubstitutor) { IProject p = getSelectedProject();
if (p == null) return ""; IManagedBuildInfo buildInfo = ManagedBuildManager.getBuildInfo(p); IConfiguration activeConfig = buildInfo.getDefaultConfiguration(); IToolChain tc = activeConfig.getToolChain(); for (IOption optn : tc.getOptions()) { if (option.getBaseId().equals("my.toolchain.compiler.model")) { if (optn.getBaseId().equals("my.toolchain.general.model")) { return "--model" + optn.getValue(); } } } return ""; } My questions are:
1. Does the command-generator always picks the saved settings (from .cproject) and not from the UI? Would even the tool-level command generator (as you recommend) do the same? Or, is above code not correct to access tool-chain option value?
2. Does pressing 'Ok' on the C++ Build Settings dialog guarantee that the settings are saved on the file-system? I've sometimes noticed that the changes done in the build-settings UI are not getting reflected in the .cproject file?
Thanks,
Ashutosh
Date: Thu, 17 Sep 2015 14:29:07 +0000 |