Re: [cdt-dev] CompletionTests and ParameterGuessingTests failing with as

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

I ended up reverting the patch that introduced parameter guessing. To prevent similar breakages in future I've added protective measures to CContentAssistInvocationContext and AbstractContentAssistTest.  A rebased version of the reverted patch is available in https://git.eclipse.org/r/#/c/41346/. It requires more work since the tests are now failing due to the protective measures added to AbstractContentAssistTest.

-sergey

On Fri, Feb 6, 2015 at 9:00 AM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:

If a solution for the performance regression is not found quickly, parameter guessing would have to be disabled until the problem is solved.

-sergey

On Fri, Feb 6, 2015 at 8:57 AM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:

I've also noticed that and am working on a fix. Unfortunately, parameter guessing caused not just a lock leak, but also a severe performance regression.

-sergey

On Fri, Feb 6, 2015 at 12:14 AM, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:

> Just wanted to give a heads up that some CompletionTests and
ParameterGuessingTests seem to be failing with assertions on trunk.
>
> You can see it in recent Hudson runs, such as https://hudson.eclipse.org/cdt/job/cdt-verify/2135/.

The tests seem to have been regressed by the fix for bug 459186.

Regards,
Nate

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev