Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-dev] Code Style for CDT code

Sorry to bring this up again, but I want to discuss this on cdt-dev.
Marc yet again -1'ed my commit because of code style, specifically because not surrounding
a single statement with braces within if operator. First of all I don't remember agreeing on any sort of code style like that (see cdt process and code style wiki), second of all I strongly disagree with this specific one. Coding style like that was created I think 20 years ago where people were
formatting code manually. Today everybody who works on cdt code should use auto-formatter.
This should be the rule, not braces.
Adding more braces actually clutters the code leading to lesser readability, and it affects all code not just "we had a case 10 years ago when somebody formatted code manually and it led to a bug".
I also strongly disagree with using code style with right side comparison like (null == a). This was created again to mitigate bad gramma of C language and it has no value in Java. It greatly impairs readability because it is not a natural order of english language, so people even they understand it eventually will had hard time reading these expressions.

Would be nice if we can actually agree of code formatting style so we can add this to our save actions, so then we don't have waste time dealing with code style and formatting on the reviews.
Note if majority of committers will agree on certain style, even I personally disagree with it I will follow it.

Back to the top