|
Derek,
DsfTerminateCommand is working fine. I was making changes in it
unrelated to this issue. At some point my changes were causing an
AssertionError being thrown from the "canExecute()" method. That's
how I noticed that other debugger buttons become disabled.
If you provide your own handlers and your customers are
experiencing the same issue you may want to check your code to
make sure that there is no uncaught exceptions in it.
Mikhail
On 05/12/2014 12:16 PM, Derek Morris wrote:
Having read these recent message, I can provide my own
DsfTerminateHandler - my product provides a GDBAdapterFactory
which creates the ITerminateHandler. So, I have added this class
and am using it instead:
public class MyDsfTerminateCommand
extends
DsfTerminateCommand {
public MyDsfTerminateCommand(DsfSession
session) {
super(session);
}
public void canExecute(final
IEnabledStateRequest request)
{
try {
super.canExecute(request);
} catch (Exception e) {
request.setEnabled(false);
request.done();
}
}
}
Is this what you were thinking? I can build this into the
product and send it to customers who are experiencing the
problem to see if it helps
Thanks!
On 5 Dec 2014, at 17:10, Mikhail Khodjaiants < mikhailkhod@xxxxxxxxxxxxxx>
wrote:
On 05/12/2014 11:39 AM,
Marc Khouzam wrote:
Should we write a bug about that to platform? Doesn't it imply that, as we saw now,
any plugin that has a problem could affect the rest of the IDE?
To be fair, Liviu's plugin didn't have a bug but triggered a platform one, but some
other plugin could just have a bug.
I was thinking about it. IMO, catching an exception in
the platform code that evaluates command's enamblement
is done too high in the stack to continue evaluating
other commands.
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
|
