Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Proposed change in thread naming

I would prefer A or B. Don't really like different types of brackets.

On 27/11/2014 4:36 PM, Marc Khouzam wrote:
Hi,

Thanks for the feedback.
So we've converged to (I've added all fields that I see in my Debug view):

A-
MyProcess [1530] [cores: 2,3]
   Thread [1] MyProcess 18787 [core: 3] (Suspended: Container)
   Thread [2] MyProcess 18788 [core: 2] (Running: Container)
   Thread [3] Worker 18789 [core: 3] (Suspended: Container)
   Thread [4] Heartbeat 18797 [core: 3] (Running: Container)

or

B -
MyProcess [1530] [cores: 2,3]
    Thread #1 [MyProcess] 18787 [core: 3] (Suspended: Container)
    Thread #2 [MyProcess] 18788 [core: 2] (Running: Container)
    Thread #3 [Worker] 18789 [core: 3] (Suspended: Container)
    Thread #4 [Heartbeat] 18797 [core: 3] (Running: Container)

I like A because it simply inserts the name of the thread into our existing format.
And I like B because putting the name in brackets makes it more understandable.  Also, thread names can have spaces, so it is good to have some kind of grouping symbol.
I tried to have a hybrid of the two:

C-
MyProcess [1530] [cores: 2,3]
   Thread [1] <MyProcess> 18787 [core: 3] (Suspended: Container)
   Thread [2] <MyProcess> 18788 [core: 2] (Running: Container)
   Thread [3] <Worker> 18789 [core: 3] (Suspended: Container)
   Thread [4] <Heartbeat> 18797 [core: 3] (Running: Container)

We had an internal discussion here and we found that the different grouping delimiter (<>) helps differentiate between different groups.  And although we liked #1, #2 for the id, we thought we would follow the current solution more and keep [1], [2].

Does someone disagree?
If not, this will become the new 'face' of the CDT Debug view for the next release.

Thanks!

Marc

-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Simon Marchi
Sent: Wednesday, November 26, 2014 10:54 AM
To: cdt-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] Proposed change in thread naming

On 2014-11-26 10:39 AM, Alena Laskavaia wrote:
In this case second set square brackets really don't add anything,so
it really becomes #1. Which is fine with me too, since it is what we
show now anyway :)

Another variant with JDT similar look

5 -
MyProcess [1530]
   Thread #1 [MyProcess] (Suspended: Container)
   Thread #2 [MyProcess] (Running: Container)
   Thread #3 [Worker] (Suspended: Container)
   Thread #4 [Heartbeat] (Running: Container)
This suggestion is the one I prefer so far.
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev



Back to the top