[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] [dsf-gdb] ExprMetaGetVarInfo
|
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Vladimir Prus
> Sent: Friday, October 31, 2014 11:26 AM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] [dsf-gdb] ExprMetaGetVarInfo
>
> On 10/31/2014 05:01 PM, Marc Khouzam wrote:
> >> -----Original Message-----
> >> From: cdt-dev-bounces@xxxxxxxxxxx
> >> [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> >> On Behalf Of Vladimir Prus
> >> Sent: Friday, October 31, 2014 3:10 AM
> >> To: CDT General developers list.
> >> Subject: [cdt-dev] [dsf-gdb] ExprMetaGetVarInfo
> >>
> >>
> >> Hi,
> >>
> >> I am looking at ExprMetaGetVarInfo and wondering whether this class
> >> is useful.
> >>
> >> Let's look at getGDBType method. The value it returns is specified
> >> when ExprMetaGetVarInfo is constructed in
> MIVariableManager.queueCommand.
> >> Then it's used in a single place, MIExpressions.getExpressionData and
> >> discarded.
> >>
> >> So this design:
> >> - introduces a new bag-of-data class, adding complexity
> >> - prevents one MI component, MIExpressions, from accessing additional
> >> data from MIVariableObject,
> >> also MI component
> >>
> >> Would it be sensible to eventually eliminate ExprMetaGetVarInfo (and
> >> possibly related classes)?
> >
> > If they can be replaced by something better. I'm not clear what you
> > suggest doing to replace them.
>
> I suggest to use MIVariableObject directly, or make ExprMetaGetVarInfo
> have no fields other than instance of MIVariableObject.
Could be nicer, especially since MIVariableObject is a public class.
However, when looking at calls to the constructor of ExprMetaGetVarInfo,
not all parameters seem to be taken from an MIVariableObject; but
maybe you'll be able work around that?
>
> --
> Vladimir Prus
> CodeSourcery / Mentor Graphics
> http://www.mentor.com/embedded-software/
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit https://dev.eclipse.org/mailman/listinfo/cdt-dev
