Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Raising the contribution limit

Thats great. I've adapted the CDT/contributing wiki page: https://wiki.eclipse.org/index.php?title=CDT%2Fcontributing&diff=366117&oldid=365998

I changed the wording slightly from "lines of code" to just lines. If I understood it correctly, according to Mike's mail every single line counts, even empty lines.

Regards
Thomas

-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Marc Khouzam
Sent: Donnerstag, 26. Juni 2014 22:06
To: 'CDT DEV (cdt-dev@xxxxxxxxxxx)'
Subject: [cdt-dev] FW: Raising the contribution limit

Great news for contributions!
Anything with less than 1000 added lines (instead of 250 lines as it was until now) does not need a Contribution Questionnaire (CQ).
And it looks like deleted lines don't count in this respect.

Bravo to the Foundation for reducing our overhead!

Marc


-----Original Message-----
From: eclipse.org-committers-bounces@xxxxxxxxxxx [mailto:eclipse.org-committers-bounces@xxxxxxxxxxx] On Behalf Of Mike Milinkovich
Sent: Thursday, June 26, 2014 3:48 PM
To: eclipse.org-committers@xxxxxxxxxxx
Cc: IP Advisory Committee; emo-ip-team@xxxxxxxxxxx
Subject: [eclipse.org-committers] Raising the contribution limit

All,

I am sure that you are aware that the Eclipse Foundation has long had a policy that required that contributions greater than 250 lines of code required the creation of a Contribution Questionnaire, and a review and approval by the IP team.

I am happy to announce that effective immediately, the requirement for filing a CQ has been raised to 1,000 lines of code added. To verify whether a contribution requires a CQ, use one of the following git commands to check:

     If it's committed:  git log --shortstat
     If not committed: git diff --stat

These commands tell you the number of insertions(+), and deletions(-). 
If the total number of lines inserted (e.g. added) in a contribution is greater than 1000 (yes, this includes comments) then a CQ is required.

I hope that this both simplifies and clarifies the expectations around accepting contributions. The other in-bound contribution requirements such as CLAs and signed-by remain in place unchanged.

Thanks!

--
Mike Milinkovich
mike.milinkovich@xxxxxxxxxxx
+1.613.220.3223 (mobile)
_______________________________________________
eclipse.org-committers mailing list
eclipse.org-committers@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse.org-committers

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top