Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] CDT 8.4 Bugs Fixed in this Release

Thanks Derek, I agree with your statements there. I've -2'ed the review.

Again, we need to rip all the Cygwin code out of the cdt core plugins and place them into an optional plug-in. We can add extension points that may be needed where there aren't suitable ones already, but the current hacks we have need to be cleaned up, and certainly not added to.

Thanks, for your help with this Francis, but we really need to make sure we manage the integrity of the CDT architecture.

Doug.

________________________________________
From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Derek Morris [dmsubs@xxxxxxxxxxxxx]
Sent: Thursday, May 29, 2014 4:51 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] CDT 8.4 Bugs Fixed in this Release

I do not like this patch and have posted my comments into the bug (117013)

I really hope it does not get applied.

On 28 May 2014, at 20:40, Doug Schaefer <dschaefer@xxxxxxx> wrote:

> Sorry, I was talking about MinGW and MSYS, which are real native gnu environments for Windows, and which get primary support from CDT (mainly because they're native and no path magic is required). I want to make sure we don't break that.
>
> Doug.
>
> ________________________________________
> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Francis ANDRE [francis.andre.kampbell@xxxxxxxxx]
> Sent: Wednesday, May 28, 2014 3:37 PM
> To: cdt-dev@xxxxxxxxxxx
> Subject: Re: [cdt-dev] CDT 8.4 Bugs Fixed in this Release
>
> Doug
>
> Le 28/05/2014 20:57, Doug Schaefer a écrit :
>> We need to find a better way to deal with Cygwin. I don't want Cygwin stuff running at all when not dealing with Cygwin.
> I do not quite understand your position. There is nothing from Cygwin
> stuff running on a non windows platform as checked in the
> Cygwin.windowsToCygwinPath method.
>
>     private static final boolean isWindowsPlatform =
> Platform.getOS().equals(Platform.OS_WIN32);
>
>
>     public static String windowsToCygwinPath(String windowsPath, String
> envPath) throws IOException, UnsupportedOperationException {
>         if (windowsPath == null || windowsPath.trim().length() == 0)
>             return windowsPath;
>
>         if (!isWindowsPlatform) {
>             throw new UnsupportedOperationException("Not a Windows
> system, Cygwin is unavailable."); //$NON-NLS-1$
>         }
>         ....
> }
>
> Francis
>> There's too much possibility for things to get messed up in native environments.
>>
>> I'm not sure what the right answer is, whether as a special Eclipse File System, but something that we can make really optional.
>>
>> Doug.
>>
>> ________________________________________
>> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Marc Khouzam [marc.khouzam@xxxxxxxxxxxx]
>> Sent: Wednesday, May 28, 2014 1:13 PM
>> To: 'cdt-dev@xxxxxxxxxxx'
>> Subject: Re: [cdt-dev] CDT 8.4 Bugs Fixed in this Release
>>
>>> -----Original Message-----
>>> From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
>>> On Behalf Of Francis ANDRE
>>> Sent: Wednesday, May 28, 2014 1:52 AM
>>> To: cdt-dev@xxxxxxxxxxx
>>> Subject: [cdt-dev] CDT 8.4 Bugs Fixed in this Release
>>>
>>> Hi
>>>
>>> I have noticed that the list of bugs fixed in CDT 8.4 version is empty
>>> -- https://wiki.eclipse.org/CDT/User/NewIn84#Bugs_Fixed_in_this_Release
>>> --
>>>
>>> Is there a way to know which bugs will be fixed in 8.4?
>>> Is there a way to include a change in this 8.4 release? (I have this one
>>> pending: https://git.eclipse.org/r/#/c/27229/)
>> Someone familiar with managed build will have to review it.
>> However, now that we are past RC2, it would have to be a very safe
>> or very important bug to risk including it.
>>
>>
>>> Rgds
>>>
>>> Francis
>>>
>>> _______________________________________________
>>> cdt-dev mailing list
>>> cdt-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top