Re: [cdt-dev] JUnit Version of org.eclipse.cdt.tests.dsf.gdb

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

I agree.  The problem is that the compilation error still happened with 4.10.0, so it wasn't sufficient to pump

the version to that.  We really would have had to pump it to 4.11 which was not part of 3.8 (although

I didn't check 3.8.2).

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Marc-André Laperle
Sent: Friday, October 11, 2013 10:32 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] JUnit Version of org.eclipse.cdt.tests.dsf.gdb

Hi,

I looked at the issue a bit previously. JUnit 4.10.0 does come with Eclipse 3.8.2 and I was wondering why it didn't use that one. I guess it uses the lowest version available by default? I'm just concerned this will happen again if we don't bump JUnit.

Marc-Andre

---

From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Marc Khouzam [marc.khouzam@xxxxxxxxxxxx]
Sent: Friday, October 11 2013 6:34 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] JUnit Version of org.eclipse.cdt.tests.dsf.gdb

Hi,

Sorry for not having noticed this problem.
I would rather change MIRegistersTest since JUnit 4.11 does not come by default on a 3.8 installation (at least not on mine).

Do you want to push the new change to the existing gerrit review, or shall I do it?

Thanks Thomas

---

From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Corbat Thomas (tcorbat@xxxxxx) [tcorbat@xxxxxx]
Sent: October 11, 2013 3:51 AM
To: CDT General developers list.
Subject: [cdt-dev] JUnit Version of org.eclipse.cdt.tests.dsf.gdb

Hi

 

Would anybody mind if we increased the JUnit version the org.eclipse.cdt.tests.dsf.gdb plug-in depends on to 4.11.0 (https://git.eclipse.org/r/#/c/17291/)? This should fix the currently failing Hudson build. Alternatively, we could change the referenced assert-methods in MIRegistersTest.

 

Regards

Thomas