[cdt-dev] CPPClassType.getVisibility(IBinding)

[Andrew Eidsness <eclipse@xxxxxxxxxx>]

I'm trying to figure out why this method doesn't check if the argument is an ICPPMember and then use
ICPPMember#getVisibility.  This seems to lead to, at least the potential for, inconsistent results with cases like
PDOMCPPAnnotation#encodeAnnotation (which does check instanceof, etc.).

To be clear, I haven't traced this to a specific problem in the core CDT, I'm just trying to figure out the motivation
behind this approach.

It does cause problems in some non-standard extensions which worked in 8.1.  Those extensions used internal types and
shouldn't be expected to continue working.  I'm trying to figure out the design goals to reduce the chance of the fix to
the non-standard extensions breaking in future releases.

Thanks,
-Andrew