Re: [cdt-dev] The process select dialog on "Attach" should react to doub

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Lidia Gutu
> Sent: Tuesday, June 25, 2013 9:56 AM
> To: cdt-dev@xxxxxxxxxxx
> Subject: [cdt-dev] The process select dialog on "Attach" 
> should react to double-click
> 
> Hello to all,
> 
> I would like to push my changes regarding the bug reported by Martin 
> Oberhuber.
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=410821
> 
> As Martin said, the double click on process from the first pane is a 
> default feature which is removed by listener from the line 104.
> 
> list.addListener(SWT.EraseItem, new Listener() {   //Line 104
> 
> I propose to comment/remove this listener and to set the second list 
> from the lower panel as disabled.
> After this changes, the double click on process will work as expected 
> and the user will be unable to select items from the lower panel.
>
> In case more than one items are displayed in the lower panel, 
> the first 
> item will have the black font color and the rest will be grey 
> color. As 
> I see, it is a default behavior for a disabled 
> org.eclipse.swt.widgets.Table.
> 
> In case you have objections to this change please let me know.

I agree the double-click missing is poor user-friendliness.
It was not what I wanted but I didn't figure out how to enable
it again, without making the bottom list editable.

I believe I originally convinced myself it was ok to leave it out as it
would prevent the user from quickly double-clicking and never
noticing a multi-selection was now supported in that dialog.
But I'll admit I might have just been giving up on finding
a fix.

I'm not thrilled about the look&feel of disabling the bottom list,
so I looked again at what was going on.  I think I found the problem
this time :).  Turns out that the double-click requires that an element
be selected in the bottom-pane also.  Once we remove this
restriction, the double-click works again.

I'll post details on the bug.

Thank you and Martin for bringing this up, it will make the dialog more
user-friendly.

Marc