Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Fix for LLVM

Yes, we could remove the page and, if necessary for includes, it could be replaced with a LLVM settings provider (scanner discovery). But that might require too much work for Kepler. As it stands, it's pretty easy to break all other projects and their configs using that preference page. Did you want to just remove the page for Kepler? To be honest, even if the LLVM feature is optional, I'd put it on hold until Luna. I don't know what other side-effects it might have before doing further testing and code review.

Also, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=405909

Marc-Andre

On 13-06-03 03:54 PM, Doug Schaefer wrote:
Oh, wait, found it in the Preferences. I'd remove that all together and initially only support LLVM on your path, like it should be on Mac and Linux.

From: Doug Schaefer <dschaefer@xxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, 3 June, 2013 3:51 PM
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] Fix for LLVM

Cool. Thanks! We'll hold off RC3 until tomorrow.

As for 406163, I'm not even sure how that's possible in the C++ Build Settings. The scope of the change is managed in the settings dialog.

D

From: Marc-André Laperle <marc-andre.laperle@xxxxxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, 3 June, 2013 3:23 PM
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] Fix for LLVM

Hi Doug,

I can review and verify the fix tonight. There is also this bug which is major, IMO:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=406163

Marc-Andre

On 13-06-03 02:24 PM, Doug Schaefer wrote:
Hey gang,

There's a pretty major bug that renders the LLVM integration useless:


I have a fix up on Gerrit:


If I can get a reviewer to take a look, I'll push this in for RC3 which is soon.

BTW, clearly not a lot of testing done for this integration. More of that would be appreciated as well :)

Thanks,
Doug.


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/cdt-dev



_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top