| Re: [cdt-dev] Close "Bug 342522 - Toggle Refactoring: Undo doesn't delete created file" as WONTFIX? |
Ah, I didn’t think to compare it to the Java refactorings – I should have done that. OK, so the right solution will have to involve putting off figuring out exactly what AST node to attach the new code to until the change is actually run. Sigh – it’ll be a mess, but I agree, that is a better solution. I’ve updated the bug accordingly. From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Prigogin Please don't close the bug as WONTFIX. File creation should be made part of the refactoring and should participate in the Undo. This is how Java refactorings that create new files work. -sergey On Thu, Apr 4, 2013 at 11:01 AM, Jesse Weinstein <jesse.weinstein@xxxxxxxxxxxxx> wrote: I think bug 342522 should be closed as WONTFIX, because we don’t allow Undo of other file creations, and the file creation here isn’t actually part of the refactoring. Since I’m not a committer, I decided to bring it to the list, so a committer (assuming they agree) can do the actually closing.
|