Re: [cdt-dev] Committing through Gerrit

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
> Sent: Monday, September 17, 2012 3:01 PM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] Committing through Gerrit
> 
> That's a good idea. BTW, I thought that's what the difference 
> between +1 and +2 was. +1 means you're OK with the change but 
> you need to +2 to actually commit it, no?

We could use that mechanism to avoid committing something we should not.

Personally, I've preferred putting +2 to show the change is 'approved'.
The description of +1 is "+1 Looks good to me, but someone else must approve".
I've seen this used by non-committers doing a review to help out but
not really wanting to say they 'approve' a change.

Imagine I, myself, make a change to Codan and put in on Gerrit.
I'd would like to get a +2 from the committers familiar with Codan since
that is not my area of expertise.  I would see a +1 as not approved yet
and would wait for a +2.

Of course, as long as we agree between ourselves, none of this is big
deal :)

Marc





> 
> D
> 
> On 12-09-17 2:56 PM, "Marc Khouzam" <marc.khouzam@xxxxxxxxxxxx> wrote:
> 
> >
> >Hi committers,
> >
> >as our use of Gerrit increases I thought I'd mention a practice we've
> >been doing in Debug.
> >When a committer reviews code from another committer, we let 
> the original
> >committer do the
> >actual commit.
> >
> >Therefore, in Gerrit, the reviewing committer would use the "Publish
> >Comments" button
> >and would leave the original committer to go to Gerrit and 
> press "Publish
> >and Submit".
> >That way, committers get to commit their own changes.
> >
> >I'm not sure if this practice is done throughout the CDT or not but I
> >thought I would 
> >suggest it as a good practice if others agree.
> >
> >Thanks
> >
> >Marc
> >
> >
> >
> >_______________________________________________
> >cdt-dev mailing list
> >cdt-dev@xxxxxxxxxxx
> >https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>