[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cdt-dev] IP and Gerrit
- From: Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>
- Date: Wed, 2 May 2012 09:41:57 -0400
- Accept-language: en-US
- Acceptlanguage: en-US
- Delivered-to: firstname.lastname@example.org
- Thread-index: AQHNKEbhZ6RVHod5ukGuNrH2C0bif5a2gOSAgAAAn7A=
- Thread-topic: [cdt-dev] IP and Gerrit
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
> Sent: Wednesday, May 02, 2012 9:37 AM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] IP and Gerrit
> I'm not sure what the state of the tooling is, but please
> mark the bug as
> iplog +1 when pushing a contribution via Gerrit. I think
The way I understand it, iplog+ on the whole bug will
trigger every non-committer that commented on the bug
to be considered to have contributed.
While iplog+ on a patch will only consider the submitter
of the patch.
I will ask the contributor to attach the final patch
to the bug and iplog+ that patch.
But I agree that iplog+ on the whole but is still
better than nothing.
> Wayne mentioned
> he was having tooling made that looks at Gerrit, but I'm not
> sure that's
> ready yet.
> On 12-05-02 5:35 AM, "Marc Khouzam" <marc.khouzam@xxxxxxxxxxxx> wrote:
> >Hi all, Doug,
> >I should be pushing a couple of contributions from Anton
> Gorenkov (xgsa@)
> >pretty soon about using Run-time type.
> >The review is done with Gerrit.
> >What do I do about the IP flag in bugzilla?
> >According to
> >"When approved, committer reflects approval on the Gerrit
> record (i.e.
> >they flip the IP bit on)."
> >"...mark contributions "IP Clean +1""
> >In bugzilla, we used to mark the ip flag as '-' for
> committers and as '+'
> >for contributions.
> >In Gerrit, we mark everything as '+1'. Is that gonna allow Doug to
> >figure out what are
> >cdt-dev mailing list
> cdt-dev mailing list