Re: [cdt-dev] Change in cdt/org.eclipse.cdt[master]: Bug 372551. Fixed r

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

I'm also not seeing anything in Gerrit. As if all reviews simply disappeared.

-sergey

On Thu, Apr 26, 2012 at 7:49 AM, Alex Ruiz <alruiz@xxxxxxxxxx> wrote:

I don't know what happened with the gerrit review. I keep getting "Not
found" errors. Any ideas?

Thanks!
-Alex

On Wed, Apr 25, 2012 at 9:25 PM, Sergey Prigogin (Code Review)
<gerrit@xxxxxxxxxxx> wrote:
> Sergey Prigogin has posted comments on this change.

>
> Change subject: Bug 372551. Fixed running checkers on file open. Split "On file save" launch mode into "On file save" and "On file open". Removed warnings in project org.eclipse.cdt.codan.ui.cxx.
> ......................................................................
>
>

> Patch Set 1: (1 inline comment)
>
> Looks good overall.
>
> ....................................................
> File codan/org.eclipse.cdt.codan.ui.cxx/src/org/eclipse/cdt/codan/internal/ui/cxx/Startup.java
> Line 68:                                                        processResource((IResource) editor.getEditorInput().getAdapter(IResource.class));
> getAdapter can return null.

>
> --
> To view, visit https://git.eclipse.org/r/5665
> To unsubscribe, visit https://git.eclipse.org/r/settings
>

> Gerrit-MessageType: comment

> Gerrit-Change-Id: I7f0bc16731ba36e8048904f19836da9ae47514de
> Gerrit-PatchSet: 1
> Gerrit-Project: cdt/org.eclipse.cdt
> Gerrit-Branch: master
> Gerrit-Owner: Alex Ruiz <alruiz@xxxxxxxxxx>

> Gerrit-Reviewer: Marc-Andre Laperle <malaperle@xxxxxxxxxxxxx>
> Gerrit-Reviewer: Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>