Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] API tooling errors 
Ok, wow, I'm impressed.  I hadn't realized PLUGIN_IN was not a string (in DSF-GDB we use a string, so I just assumed).
My apologies to the writer of the API tool!

Thanks Doug.
________________________________________
From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer [cdtdoug@xxxxxxxxx]
Sent: March 1, 2012 2:25 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] API tooling errors

On Thu, Mar 1, 2012 at 2:15 PM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:
> Thanks Doug, I see the errors also now.
>
> Note that it does not fix the other bug I mentioned:
>>>> 1- Change the string value of ICDebugConstants.DEF_CHARSET and save.  I get an API-tool error
>>>> 2- Change the string value of ICDebugConstants.PREF_STEP_MODE and save.  I get no error. ???

That's not really a bug. DEF_CHARSET is a proper String constant which
can be inlined at sites where it's used causing an inconsistency if it
is changed. PREF_STEP_MODE actually is not a constant due to the
plug-in ID. It is calculated in the static initializer for the class
and all users reference the value from the class.

In fact, that gives me more confidence in the API tooling that it is
doing a deep analysis on what is really is API impacting or not.

> but I think we should use the procedure you just described to setup the API tool from now one.
> I will update the wiki page:
> http://wiki.eclipse.org/CDT/policy#Using_API_Tooling
> ________________________________________
> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer [cdtdoug@xxxxxxxxx]
> Sent: March 1, 2012 10:31 AM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] API tooling errors
>
> Yes, extract a 3.7.0 platform (or Eclipse SDK), launch it and point p2
> at the cdt-master-8.0.0.zip archive, uncheck the show categories and
> select all the features in the zip and install them. There must be
> something that needs a proper p2 install for the API tooling to work.
>
> On Thu, Mar 1, 2012 at 10:10 AM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:
>> So you install a 3.7 eclipse.  You then install all the CDT features using p2?
>> Then, where do you point your development eclipse for a baseline?  At the new
>> installation plugins directory?
>> ________________________________________
>> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer [cdtdoug@xxxxxxxxx]
>> Sent: March 1, 2012 10:02 AM
>> To: CDT General developers list.
>> Subject: Re: [cdt-dev] API tooling errors
>>
>> Ah-ha! I got it. I can now reproduce the errors. Simply extracting the
>> master zip file and pointing the API Baseline at it, although lists
>> the plug-ins, doesn't work. You have to install all the features into
>> an Eclipse platform and point at that.
>>
>> On Thu, Mar 1, 2012 at 9:25 AM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:
>>> We could probably revert the change to those classes to be totally safe, although it would be less elegant.
>>> Let's wait for Mikhail to give his recommendation.
>>> ________________________________________
>>> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer [cdtdoug@xxxxxxxxx]
>>> Sent: March 1, 2012 9:17 AM
>>> To: CDT General developers list.
>>> Subject: Re: [cdt-dev] API tooling errors
>>>
>>> I do know of vendors subclassing the GDBControl classes. We need to be
>>> absolutely sure it is compatible.
>>>
>>> On Thu, Mar 1, 2012 at 9:14 AM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:
>>>>
>>>> I'm starting to worry about the API tool.  I've hit suspicious behavior many times now.
>>>> Looking at the errors Sergey mentions, they do make sense.  We have changed the base
>>>> class of a public class, and I guess the API-tool should have reported a problem.
>>>> It still does not for me.
>>>>
>>>> That being said, the change made is done in such a way that I believe it will not actually
>>>> break the API, because the new base class, is a copy/pasted identical class as the previous
>>>> one.  In that case, I think it would be ok to use an API filter to get rid of the warning.  We may
>>>> need Sergey's help to create the filter, since none of us can see the API error :)
>>>>
>>>> To show the API-tool flakiness, can someone else try this:
>>>> 1- Change the string value of ICDebugConstants.DEF_CHARSET and save.  I get an API-tool error
>>>> 2- Change the string value of ICDebugConstants.PREF_STEP_MODE and save.  I get no error. ???
>>>>
>>>> Thanks
>>>>
>>>> Marc
>>>> ________________________________________
>>>> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer [cdtdoug@xxxxxxxxx]
>>>> Sent: March 1, 2012 8:56 AM
>>>> To: CDT General developers list.
>>>> Subject: Re: [cdt-dev] API tooling errors
>>>>
>>>> Ah, I mislabelled. I am using 8.0.0. Sergey, what are you using? I've
>>>> been wondering if simply extracting the master zip actually worked
>>>> since it's a p2 repo, not an eclipse install (although they are very
>>>> close).
>>>>
>>>> On Wed, Feb 29, 2012 at 11:21 PM, Mikhail Khodjaiants
>>>> <mikhailkhod@xxxxxxxxxxxxxx> wrote:
>>>>> On 29/02/2012 11:13 PM, Doug Schaefer wrote:
>>>>>
>>>>> I just tried it myself and I don't see anything. I'm using the
>>>>> cdt-master-8.0.2.zip extracted as my baseline (and yes, we should
>>>>> really be using 8.0.0). Is that what others are doing?
>>>>>
>>>>> I am using 8.0.0 as my baseline.
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> cdt-dev mailing list
>>>>> cdt-dev@xxxxxxxxxxx
>>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>>>
>>>> _______________________________________________
>>>> cdt-dev mailing list
>>>> cdt-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>> _______________________________________________
>>>> cdt-dev mailing list
>>>> cdt-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>> _______________________________________________
>>> cdt-dev mailing list
>>> cdt-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>> _______________________________________________
>>> cdt-dev mailing list
>>> cdt-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

Back to the top