Re: [cdt-dev] External-tool-based checkers for Codan

[Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>]

I left comments in this pr

On Sat, Feb 25, 2012 at 12:15 PM, Sergey Prigogin
<eclipse.sprigogin@xxxxxxxxx> wrote:
>
>
> On Sat, Feb 25, 2012 at 7:25 AM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
> wrote:
>>
>> Would be nice to review design and API too before committing, at least
>> let ME know what are you up too
>
>
> Unfortunately, due to EGit limitations it was hard to produce a single patch
> for the contribution. It's not too late to review the API and the design now
> since everything can still be changed.
>
> -sergey
>>
>>
>> On Fri, Feb 24, 2012 at 9:25 PM, Sergey Prigogin
>> <eclipse.sprigogin@xxxxxxxxx> wrote:
>> >
>> >
>> > On Fri, Feb 24, 2012 at 4:06 PM, Marc Khouzam
>> > <marc.khouzam@xxxxxxxxxxxx>
>> > wrote:
>> >>
>> >> Thanks Alex and Sergey, this seems like a really cool addition to CDT.
>> >>
>> >> For the record, I have to agree with Doug that there really should be a
>> >> bugzilla
>> >> associated with commits that contain functionality.  There is the
>> >> aspect
>> >> of openness
>> >> where a bugzilla allows others to join in the discussion; and there is
>> >> the
>> >> availability
>> >> of information about the feature.  Without the bug, there is no way to
>> >> get
>> >> information
>> >> about the complex commits that come with such a feature.
>> >
>> >
>> > Point taken. In the spirit that better late than never, Alex
>> > created https://bugs.eclipse.org/bugs/show_bug.cgi?id=372551. Please
>> > share
>> > your criticisms and ideas there.
>> >>
>> >>
>> >> Next time :)
>> >>
>> >> Marc
>> >
>> >
>> > -sergey
>> >>
>> >>
>> >>
>> >> ________________________________________
>> >> From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On
>> >> Behalf
>> >> Of Doug Schaefer [cdtdoug@xxxxxxxxx]
>> >> Sent: February 24, 2012 12:41 PM
>> >> To: CDT General developers list.
>> >> Subject: Re: [cdt-dev] External-tool-based checkers for Codan
>> >>
>> >> Ideally it contains the design discussion you had with the community
>> >> too
>> >> ;)
>> >>
>> >> On Fri, Feb 24, 2012 at 12:28 PM, Alex Ruiz <alruiz@xxxxxxxxxx> wrote:
>> >> > Hi Doug,
>> >> >
>> >> > I didn't create a bugzilla ticket, but I'll create one. Should the
>> >> > ticket
>> >> > point to the commit in git?
>> >> >
>> >> > Many thanks,
>> >> > -Alex
>> >> >
>> >> >
>> >> > On Fri, Feb 24, 2012 at 9:03 AM, Doug Schaefer <cdtdoug@xxxxxxxxx>
>> >> > wrote:
>> >> >>
>> >> >> Thanks, Alex. Was there a bugzilla number that documented this work?
>> >> >>
>> >> >> Doug.
>> >> >>
>> >> >> On Fri, Feb 24, 2012 at 7:50 AM, Alex Ruiz <alruiz@xxxxxxxxxx>
>> >> >> wrote:
>> >> >> > Greetings,
>> >> >> >
>> >> >> > I've been working on infrastructure for external-tool-based
>> >> >> > checkers
>> >> >> > for
>> >> >> > Codan. The work started some time ago when we wanted to integrate
>> >> >> > CDT
>> >> >> > with
>> >> >> > some code checking tools that we have internally at Google. Then
>> >> >> > the
>> >> >> > common
>> >> >> > pieces were abstracted and now are part of CDT.
>> >> >> >
>> >> >> > Many thanks to my teammate and mentor, Sergey Prigogin, for his
>> >> >> > guidance
>> >> >> > and
>> >> >> > for reviewing, improving and committing this work.
>> >> >> >
>> >> >> > I wrote a little blog entry explaining this new infrastructure.
>> >> >> > BTW,
>> >> >> > the
>> >> >> > infrastructure includes a checker that integrates with Cppcheck
>> >> >> > (disabled by
>> >> >> > default.) You can read the post
>> >> >> > at http://alexruiz.developerblogs.com/?p=2231
>> >> >> >
>> >> >> > Feedback is always welcome :)
>> >> >> >
>> >> >> > Best regards,
>> >> >> > -Alex
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > _______________________________________________
>> >> >> > cdt-dev mailing list
>> >> >> > cdt-dev@xxxxxxxxxxx
>> >> >> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >> >> >
>> >> >> _______________________________________________
>> >> >> cdt-dev mailing list
>> >> >> cdt-dev@xxxxxxxxxxx
>> >> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >> >
>> >> >
>> >> >
>> >> > _______________________________________________
>> >> > cdt-dev mailing list
>> >> > cdt-dev@xxxxxxxxxxx
>> >> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >> >
>> >> _______________________________________________
>> >> cdt-dev mailing list
>> >> cdt-dev@xxxxxxxxxxx
>> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >> _______________________________________________
>> >> cdt-dev mailing list
>> >> cdt-dev@xxxxxxxxxxx
>> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >
>> >
>> >
>> > _______________________________________________
>> > cdt-dev mailing list
>> > cdt-dev@xxxxxxxxxxx
>> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>