Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Gerrit

If all the decisions made around the code are easily traceable
I'm hopeful again :)
(not that bugzilla makes it _easy_ all the time, but at least
it is available).

I like your point about having access to such design discusssions
while disconnected.

I guess I just have to try Gerrit to realize what it can do.

Thanks for the info.

Marc


> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Alex Blewitt
> Sent: Friday, February 17, 2012 4:23 AM
> To: CDT General developers list.
> Cc: CDT General developers list.
> Subject: Re: [cdt-dev] Gerrit
> 
> Discussions on Gerrit are arguably more useful with code 
> since it often involves specifics. You can also annotate 
> lines individually rather than just "please modify the method 
> in this class" comments in bugzilla. 

> For non-code decisions (big designs, debates about 
> approaches) then bugzilla may be more appropriate. 
> 
> You can also have Gerrit send mail of changes (like bugzilla) 
> and pick up new elements via Mylyn reviews (like bugzilla). 

> I see bugzilla less useful that Gerrit for almost every 
> purpose, and if you give the Mylyn integration a go so may you. 
> 
> Finally having details outside the git repo actually goes 
> against the benefits of a DVCS in that you can be 
> disconnected. ECF is a great example of how not to do this; 
> every commit is just a pointer to a bug. That makes no sense 
> when disconnected. 
> 
> However it's conventional to have a Key: Value at the bottom 
> of the commit message, such as
> 
> Bug: 12345
> 
> That way people have a link if needed, but the message should 
> still be standalone in intent and detail. 
> 
> Alex
> 
> Sent from my iPhone  4S
> 
> On 17 Feb 2012, at 07:48, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
> 
> > At the same time Gerrit is a very good code review tool, something
> > Bugzilla is not. I don't mind seeing design discussions on bugzilla,
> > and if we make sure we put the link  to the changeset in the bug and
> > visa versa, navigation between the tools should be easy.
> > 
> > I just want to take advantage of the great git integration 
> that gerrit
> > provides. Never again should we have to ask someone to update and
> > resubmit a patch. You simply rebase it from the current branch head.
> > 
> > Doug.
> > 
> > On Thu, Feb 16, 2012 at 8:16 PM, Marc Khouzam 
> <marc.khouzam@xxxxxxxxxxxx> wrote:
> >> I totally agree with M-A on this.  The discussions on 
> Bugzilla are extremely valuable.
> >> 
> >> I'm suddenly worried about using Gerrit, now that M-A 
> brings up this point.
> >> 
> >> 
> >> Best regards,
> >> 
> >> Marc
> >> 
> >> 
> >> ----- Original Message -----
> >> From: Marc-Andre Laperle <malaperle@xxxxxxxxxxxxx>
> >> To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
> >> Sent: 16-02-2012 21:45
> >> Subject: Re: [cdt-dev] Gerrit
> >> 
> >> 
> >> 
> >> Hi Doug,
> >> 
> >> Gerrit looks great! My only concern is that it could move 
> too much of
> >> the discussions from Bugzilla to Gerrit. Often when I look 
> at EGit bugs,
> >> I don't see a lot of activity and updates and then I find 
> out everything
> >> is happening on Gerrit. If we adopt it, I think we should make sure
> >> Bugzilla is not too left out.
> >> 
> >> Marc-Andre
> >> 
> >> On 13/02/2012 2:32 PM, Doug Schaefer wrote:
> >>> Hey gang,
> >>> 
> >>> Gerrit is ready for us to use! Woo hoo!
> >>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=283749#c141
> >>> 
> >>> I haven't taken a look at how to set it up and what it 
> means to our
> >>> processes. But it's something that should make our lives 
> easier when
> >>> accepting contributions. Let me know what you think and 
> whether and we
> >>> we should adopt it.
> >>> 
> >>> Thanks,
> >>> Doug.
> >>> _______________________________________________
> >>> cdt-dev mailing list
> >>> cdt-dev@xxxxxxxxxxx
> >>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >> 
> >> _______________________________________________
> >> cdt-dev mailing list
> >> cdt-dev@xxxxxxxxxxx
> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >> _______________________________________________
> >> cdt-dev mailing list
> >> cdt-dev@xxxxxxxxxxx
> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 

Back to the top