[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Hi,
I'm a big fan of code reviews, so I think anything helping
making them easier for CDT is a good thing.
I've never used Gerrit yet (outside the EclipseCon tutorials :)),
but if we look at how well our migration to Git went,
moving to use Gerrit does not worry me too much.
However, currently, I find that getting committer changes
reviewed by another committer does not happen all the time, and
I wouldn't want to prevent changes to go in because of that.
So, I think using Gerrit is a good idea as long as committers
can still approve their own changes, as you suggest.
Thanks
Marc
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
> Sent: Monday, February 13, 2012 2:39 PM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] Gerrit
>
> The biggest thing I see is that we have a choice of whether to have
> committers go through Gerrit as well or allow back door access.
>
> My understanding is that you can review your own changes and commit
> them and that makes changes to the repo more visible to everyone. So
> I'm in favor of having everyone use Gerrit.
>
> Let me know what you think.
> Doug.
>
> On Mon, Feb 13, 2012 at 12:32 PM, Doug Schaefer
> <cdtdoug@xxxxxxxxx> wrote:
> > Hey gang,
> >
> > Gerrit is ready for us to use! Woo hoo!
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=283749#c141
> >
> > I haven't taken a look at how to set it up and what it means to our
> > processes. But it's something that should make our lives easier when
> > accepting contributions. Let me know what you think and
> whether and we
> > we should adopt it.
> >
> > Thanks,
> > Doug.
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
