Re: [cdt-dev] Fix for bug 307311

[Mathias Kunter <mathiaskunter@xxxxxxxxx>]

Marc,

thank you very much for your quick response. I gladly answer any 
questions which may arise concerning the patch. Please just let me know.

Thank you,
Mathias


Am 01.12.2011 16:06, schrieb Marc Khouzam:
> Hi Mathias,
>
> I had a look yesterday, but I will need more time
> to understand the details of the problem.
>
> We should be able to get this in before the end of
> the month.
>
> Thanks again for you patience.
>
> Marc
>
>
> > -----Original Message-----
> > From: cdt-dev-bounces@xxxxxxxxxxx
> > [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Mathias Kunter
> > Sent: Wednesday, November 30, 2011 3:04 PM
> > To: CDT General developers list.
> > Subject: Re: [cdt-dev] Fix for bug 307311
> >
> > Dear members / committers of the Eclipse CDT project,
> >
> > I may try again to convince any of the committers of Eclipse CDT to
> > review the patch for bug 307311 (UTF-8 support for debugging views)
> > which I've submitted to Bugzilla about 4 months ago.
> >
> > Bugzilla link: https://bugs.eclipse.org/bugs/show_bug.cgi?id=307311
> >
> > The review shouldn't take long - it's just about 100 lines of very
> > cleanly written code (200 including comments), and I also spent much
> > time testing this. So it really should work. See
> > https://bugs.eclipse.org/bugs/attachment.cgi?id=200939 for a
> > verification that the patch is actually generally working.
> >
> > The review might just primarily cover the question whether
> > MIVarEvaluateExpressionInfo and MIDataEvaluateExpressionInfo
> > should call
> > MIConst.getString() then instead of MIConst.getCString() in order to
> > support Unicode for evaluated expressions as well.
> >
> > One final note: gdb's charset must be set to either UTF-8 or
> > ISO-8859-1
> > in order to enable this patch to correctly recognize all
> > UTF-8 strings
> > (should be the default setting anyway on Linux / Mac, but not on
> > Windows). You may use the gdb commands "set charset UTF-8" or "set
> > charset ISO-8859-1" for that. More details about this can be found
> > within the comments I made on the bug report.
> >
> > Thank you very much for your valued time and work.
> >
> > Best regards,
> > Mathias Kunter