Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Requesting review of new patch for internal-builder library dependencies bug 210248

Thanks, Doug, for your comments on the patch in bugzilla.  I've tried to address your EFS concerns, though it seems to me that the project build settings API isn't set up to handle anything but local filesystem so I didn't quite know how to test, for example, a remote FS.

Any volunteers to review the amended patch?  It passes the same tests to which I subjected the previous iteration.

Thanks,

Christian


On 2011-11-04, at 11:17 AM, Schaefer, Doug wrote:

I don't think James spends much time on CDT any more. I'll take a look, though. I'm looking at ways to improve the build UI at the moment.

Thanks!
Doug.

-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Alena Laskavaia
Sent: Friday, November 04, 2011 11:04 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] Requesting review of new patch for internal-builder
library dependencies bug 210248

I reviewed that but would be nice if somebody from build guys can review it
too James, Andrew?

On Fri, Nov 4, 2011 at 10:48 AM, Christian Damus <CDamus@xxxxxxx>
wrote:
Hi, all,
I've attached an updated patch with a description of the changes and
testing to bug 210248, about failure of the internal builder to
rebuild an executable project when a library that it links has been updated:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=210248#c14

I would very much appreciate a committer's time to review this patch
and, one hopes, to commit it.  The patch targets the 8.0.x maintenance
branch; it would be nice to see this in the next 8.0.x release, but of
course that's up to the committers to decide.
Thanks in advance,
Christian
----
Christian W. Damus
Software Developer, IDE Team
QNX Software Systems Limited <http://www.qnx.com/>


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

----
Christian W. Damus
Software Developer, IDE Team
QNX Software Systems Limited <http://www.qnx.com/>


Back to the top