Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Mavenize cdt_7_0

Well, if I have to hazard a guess, I’d put the profile in the pom.xml file for cdt.repo. I think the pluginRepositories part probably should go in the top level pom with the rest of them.

 

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent: Wednesday, July 06, 2011 3:15 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] Mavenize cdt_7_0

 

So would I be adding the profile to pom.xml in cdt.repo or the top level pom.xml?

If I'm adding to top level pom.xml, where should I add the profile?

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab

Inactive hide details for "Schaefer, Doug" ---07/06/2011 03:12:25 PM---That would be the org.eclipse.cdt.repo project. From: cd"Schaefer, Doug" ---07/06/2011 03:12:25 PM---That would be the org.eclipse.cdt.repo project. From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bo


From:


"Schaefer, Doug" <Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <cdt-dev@xxxxxxxxxxx>


Date:


07/06/2011 03:12 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx





That would be the org.eclipse.cdt.repo project.

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Wednesday, July 06, 2011 3:04 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

Ah I see.

I found this post about Eclipse signing with Tycho:
http://aniszczyk.org/2011/05/18/eclipse-org-signing-support-for-maven-tycho/

It said to add the profile to the module that generates the p2 repository. Which module is that for our build?

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab

Inactive hide details for "Schaefer, Doug" ---07/06/2011 02:12:21 PM---Excellent :). For #1, these platforms have been removed "Schaefer, Doug" ---07/06/2011 02:12:21 PM---Excellent :). For #1, these platforms have been removed from Eclipse 3.7 and maven fails when trying


From:


"Schaefer, Doug" <Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <cdt-dev@xxxxxxxxxxx>


Date:


07/06/2011 02:12 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx






Excellent
J.

For #1, these platforms have been removed from Eclipse 3.7 and maven fails when trying to build for them (no SWT fragment). They might be still there in 3.6. This is one area where maven is more picky than PDE build. Note that when adding them back, make sure you add the <environment> entries to the root pom.xml file as well.


For #2, I remove the source bundles from the non-Java projects since maven was failing on them. If there’s no source, there’s no need for a source bundle I guess. Unless it causes problems on the upgrade, I’d say it’s fine.


Doug



From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Wednesday, July 06, 2011 1:57 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

Thanks so much Doug!

I got Maven setup on my Windows laptop and kicked off a test build.

I compared the build I got (org.eclipse.cdt.repo.zip) to the last 7.0.x build and saw these differences:

1. cdt.core.ia64, cdt.core.ppc, cdt.core.qnx are missing
2.
source bundles for some of the cdt.core.[platform] plugins are not generated
3.
sdk feature and source feature/bundles for cdt.xlc and cdt.core.parser.upc features are not generated


I think I can fix #1 but for 2 and 3 I'm not sure how to fix them and I need your help.

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab

Inactive hide details for "Schaefer, Doug" ---07/05/2011 11:06:47 PM---I pushed my final changes. cdt_7_0 builds for me. I have"Schaefer, Doug" ---07/05/2011 11:06:47 PM---I pushed my final changes. cdt_7_0 builds for me. I haven't tried it mind you to make sure it actual


From:


"Schaefer, Doug" <
Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 11:06 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx







I pushed my final changes. cdt_7_0 builds for me. I haven’t tried it mind you to make sure it actually runs.

Cheers and thanks Vivian,
Doug


From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Tuesday, July 05, 2011 8:48 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

Thanks!

I have just made a few more changes:
- Add Codan feature to top level pom.xml (since Codan wasn't part of the cdt feature in cdt_7_0)
- Add pom.xml to codan feature
- change lrparser project names
- update category.xml and add codan, lrparser, p2 features

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab


Inactive hide details for "Schaefer, Doug" ---07/05/2011 07:33:13 PM---Actually, I think Mike K asked us to remove the c99 plug"Schaefer, Doug" ---07/05/2011 07:33:13 PM---Actually, I think Mike K asked us to remove the c99 plugins and that they weren't used anywhere. I h


From:


"Schaefer, Doug" <
Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 07:33 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx








Actually, I think Mike K asked us to remove the c99 plugins and that they weren’t used anywhere.

I have a few changes that I’m working on. I’ll rebase and push them when I get a successful build running.

:D


From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Tuesday, July 05, 2011 7:29 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

Nevermind I can change the project names in my workspace.

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab


Inactive hide details for Vivian Kong---07/05/2011 07:26:34 PM---Thanks Doug.  I have updated the msw feature and plugin from tVivian Kong---07/05/2011 07:26:34 PM---Thanks Doug. I have updated the msw feature and plugin from the top level pom.xml


From:


Vivian Kong/Toronto/IBM@IBMCA


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 07:26 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx









Thanks Doug. I have updated the msw feature and plugin from the top level pom.xml

Finally know why I don't see lrparser and lrparser.test plugins. They are named o.e.cdt.core.parser.c99 and o.e.cdt.core.parser.c99.tests for some reason. Can we change this?

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab


Inactive hide details for "Schaefer, Doug" ---07/05/2011 05:51:09 PM---Running a test build now. You need to remove the msw plu"Schaefer, Doug" ---07/05/2011 05:51:09 PM---Running a test build now. You need to remove the msw plug-in and feature from the top level pom.xml.


From:


"Schaefer, Doug" <
Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 05:51 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx









Running a test build now. You need to remove the msw plug-in and feature from the top level pom.xml.

Still not sure what you mean by the lrparser stuff missing. I have it here. In fact you put the pom.xml files into those projects directories.


From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Tuesday, July 05, 2011 5:42 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

I have check in my changes so far to cdt_7_0. I'd appreciate it if you can take a look and see if I missed anything. Thanks.

The lrparser and lrparser.tests plugins are missing in the cdt_7_0 branch and they were in cdt_7_0 in CVS. Were they missed when we move to Git?

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab


Inactive hide details for "Schaefer, Doug" ---07/05/2011 05:36:21 PM---Also bring the .gitignore file from the root over too to"Schaefer, Doug" ---07/05/2011 05:36:21 PM---Also bring the .gitignore file from the root over too to hide the bin and target directories. From:


From:


"Schaefer, Doug" <
Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 05:36 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx










Also bring the .gitignore file from the root over too to hide the bin and target directories.


From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Schaefer, Doug
Sent:
Tuesday, July 05, 2011 5:18 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0


Not sure what you mean. If a feature isn’t in CDT 7.0.x then you can’t add it now. That would require a release review.


From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Tuesday, July 05, 2011 4:28 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

I just realize org.eclipse.cdt.core.lrparser and org.eclipse.cdt.core.lrparser.tests plugins are not in cdt_7_0. Can you please add them back?

Also, should org.eclipse.cdt.msw-feature be in cdt_7_0 as well?

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab


Inactive hide details for "Schaefer, Doug" ---07/05/2011 03:58:12 PM---And, yes the repo. That's the project that builds the p2"Schaefer, Doug" ---07/05/2011 03:58:12 PM---And, yes the repo. That's the project that builds the p2 repo. It replaces the master feature. You n


From:


"Schaefer, Doug" <
Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 03:58 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx











And, yes the repo. That’s the project that builds the p2 repo. It replaces the master feature. You need that too
J.

From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Tuesday, July 05, 2011 3:54 PM
To:
CDT General developers list.
Subject:
Re: [cdt-dev] Mavenize cdt_7_0

Oh and what is org.eclipse.cdt.repo? Do I need to create that in cdt_7_0?

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab


Inactive hide details for "Schaefer, Doug" ---07/05/2011 03:49:06 PM---No, I just use the XML Editor from the Indigo repo, or e"Schaefer, Doug" ---07/05/2011 03:49:06 PM---No, I just use the XML Editor from the Indigo repo, or even emacs. They're pretty simple files. They


From:


"Schaefer, Doug" <
Doug.Schaefer@xxxxxxxxxxxxx>


To:


"CDT General developers list." <
cdt-dev@xxxxxxxxxxx>


Date:


07/05/2011 03:49 PM


Subject:


Re: [cdt-dev] Mavenize cdt_7_0


Sent by:


cdt-dev-bounces@xxxxxxxxxxx












No, I just use the XML Editor from the Indigo repo, or even emacs. They’re pretty simple files.

They key is to get maven 3.0.3 from apache and then run:

.../apache-maven-3.0.3/bin/mvn clean install

>From the root repo directory.

If you commit and push the poms, I can take a quick look. The key one will be the root pom.xml that specifies things like p2 repo locations and the list of modules (i.e. projects) that will be built. Not sure if any of the structure has changed since 7.0.

:D


From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Vivian Kong
Sent:
Tuesday, July 05, 2011 3:43 PM
To:
cdt-dev@xxxxxxxxxxx
Subject:
[cdt-dev] Mavenize cdt_7_0

Hi Doug,

I'm copying all the pom.xml files from master to cdt_7_0. Is there a tool that you use to edit these files (e.g. m2eclipse)? Is that all I need to do in terms of setting up the features and plugins?

If you have a checklist of what you did that you can send me (or put it up on the wiki) that'd be great. Thanks.

Regards,

Vivian Kong
IBM Eclipse CDT
IBM Canada Toronto Lab
_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list

cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top