Re: [cdt-dev] Codan preferences

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

I've moved the PreferenceInitializer to Codan core.

-sergey

On Fri, May 13, 2011 at 7:05 PM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:

On Fri, May 13, 2011 at 6:59 PM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx> wrote:

Can you do it? I am off next week

I have trouble understanding all the profile stuff. One thing that confuses me is IPreferenceStore store = CodanUIActivator.getDefault().getPreferenceStore(); line in PreferenceInitializer that seems to indicate that the preferences live in org.eclipse.cdt.codan.ui, but at the same time they are accessed from org.eclipse.cdt.codan.core. Not sure how it happens.

-sergey

On Fri, May 13, 2011 at 9:34 PM, Sergey Prigogin

<eclipse.sprigogin@xxxxxxxxx> wrote:
> Please make sure to sync to get my latest changes
> for https://bugs.eclipse.org/bugs/show_bug.cgi?id=345793.
> -sergey
>
> On Fri, May 13, 2011 at 6:25 PM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
> wrote:
>>
>> Sounds like a plan. I am glad it is "internal" :)
>>
>> On Fri, May 13, 2011 at 9:21 PM, Sergey Prigogin
>> <eclipse.sprigogin@xxxxxxxxx> wrote:
>> >
>> >
>> > On Fri, May 13, 2011 at 6:14 PM, Alena Laskavaia
>> > <elaskavaia.cdt@xxxxxxxxx>
>> > wrote:
>> >>
>> >> Not sure. They are in core because they suppose to be used by headless
>> >> build. What do you mean initialized?
>> >
>> > org.eclipse.cdt.codan.internal.ui.preferences.PreferenceInitializer
>> > lives
>> > in org.eclipse.cdt.codan.ui. I think it should be moved
>> > to org.eclipse.cdt.codan.core.
>> > -sergey
>> >>
>> >> On Fri, May 13, 2011 at 8:54 PM, Sergey Prigogin
>> >> <eclipse.sprigogin@xxxxxxxxx> wrote:
>> >> > Hi Alena,
>> >> > I've noticed that Codan preferences that are defined in
>> >> > org.eclipse.cdt.codan.core are initialized in
>> >> > org.eclipse.cdt.codan.ui.
>> >> > This
>> >> > seems pretty dangerous since the preferences can potentially be
>> >> > accessed
>> >> > from org.eclipse.cdt.codan.core before being initialized. Could
>> >> > please
>> >> > shed
>> >> > some light on this. Thanks.
>> >> > -sergey
>> >
>> >
>
>