| [cdt-dev] IPinModelListener interface change |
|
Hi, I am seeing a problem with the pin and clone feature when
cores/thread are grouped. Here is the scenario, pin Variables <1> view to
threadA and Variables <2> view to threadB, than select the group and
perform step/resume. The views should update when the threads are suspended,
this is not the case at the moment. I would like to make a small change to the interface to
address this issue, IPinModelListener, to have an additional parameter to the
modelChanged method and rename the constants to better fit the meaning of the model
update event notification. If model changed, the model will fire the INVALIDATE
change event, which cause the pinned views to update with the new selection. Here is the modified interface: /** *
A callback interface that can be used by an IPinProvider to indicate *
that the model has changed for a pinned view and that the view must be *
refreshed. * *
@noimplement This interface is
not intended to be implemented by clients. */ public interface IPinModelListener {
/**
* The pinned context is invalid, the view should blank out.
*/
static final int INVALID =
0;
/**
* The pinned context is invalid, the view should update it to the new
selection.
*/
static final int INVALIDATE = 1;
/**
* Notify model changed, update the view.
*
* @param eventType one of the event type
* @param selection the selection, can be {@code null}
*
*/
void modelChanged(int eventType,
ISelection selection); } Also, this should help to address the disassembly issue (337376) as well,
but required additional changes to the selection policy. Is anyone have any concern regarding the interface change? Thanks, Patrick |