Re: [cdt-dev] PDOMCPPBinding.getQualifiedNameCharArray vs PDOMBinding.ge

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

I'm going to redefine both PDOM*Binding methods to delegate to CPPVisitor ones.

-sergey

On Wed, Mar 9, 2011 at 4:54 AM, Schorn, Markus <Markus.Schorn@xxxxxxxxxxxxx> wrote:

Hi Sergey,

The history shows that this piece of code was introduced with the initial representation of instances in the index (https://bugs.eclipse.org/bugs/show_bug.cgi?id=167098).

 

There were many issues with this representation. It also put template instances below the original binding (rather than the actual owner) in the PDOM hierarchy. I guess the extra condition was put into ‘getQualifiedNameCharArray’ to (partially) work around this.

 

Today I think it would be most consistent to rely on CPPVisitor.getQualifiedName() and CPPVisitor.getQualifiedNameCharArray().

 

Markus.

 

 

 

 

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Prigogin
Sent: Wednesday, March 09, 2011 5:59 AM
To: CDT General developers list.
Subject: [cdt-dev] PDOMCPPBinding.getQualifiedNameCharArray vs PDOMBinding.getQualifiedName
Importance: Low

 

PDOMCPPBinding.getQualifiedNameCharArray and PDOMBinding.getQualifiedName methods may produce semantically different results due to !(node instanceof ICPPTemplateInstance) condition that is present in the first method, but not in the second one. Is it an oversight, or there is some mysterious truth behind it?

 

-sergey

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev