[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] Unlink Disassembly View
|
Thanks Toni, I have filed a bugzilla for the feature request.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=326670
Regards,
Patrick
-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Leherbauer, Anton (Toni)
Sent: Thursday, September 30, 2010 3:36 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] Unlink Disassembly View
Hi,
the DSF Disassembly already exists in two flavours - as view and as editor.
Most of the code is in shared in DisassemblyPart.
It is simply not used as editor at the moment, but a quick test
shows that it is also functional as editor (with a few tweaks here and there).
What is missing is the integration into the source lookup/display logic.
This probably needs some work and thoughts about the desired workflow
and granularity of disassembly editors (e.g. one for all, one per address space, etc.),
but the major building blocks are there.
Another point to consider is that an editor does not have a local toolbar.
A possible solution might be to add a toolbar inside the editor.
I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=326636 for that.
Patrick, please file a bug about the "Unlink" and expression re-evaluation
feature.
Thanks,
Toni
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
> Sent: Wednesday, September 29, 2010 7:49 PM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] Unlink Disassembly View
>
> There already is an Disassembly editor in the CDT. I've asked Toni to
> take a look at it and see if we can get it working.
>
> D.
>
> On Wed, Sep 29, 2010 at 1:38 PM, Pawel Piech
> <pawel.piech@xxxxxxxxxxxxx> wrote:
> > Unfortunately, from Mikhail's comments it doesn't seem like
> the work he did
> > would be applicable to the current disassembly view. I
> don't know whether
> > Wind River's editor integration could be easily contributed
> or if it's too
> > different, I'll let Toni comment on that. I also don't know about
> > expression re-evaluation, but the unlink feature would need
> to solve the
> > same problems as the proposed pin and clone feature in platform.
> > Cheers,
> > Pawel
> >
> > On 09/29/2010 10:12 AM, Chuong, Patrick wrote:
> >
> > How far away from having the view moved to the editor? Is
> this feasible
> > within the next couple of months, if not, can the current
> DSF disassembly
> > view enhanced to support unlink and re-evaluation
> expression for suspended
> > event? I can help out in this area.
> >
> >
> >
> > Regards,
> >
> > Patrick
> >
> >
> >
> > ________________________________
> >
> > From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On
> > Behalf Of Pawel Piech
> > Sent: Wednesday, September 29, 2010 1:02 PM
> > To: CDT General developers list.
> > Subject: Re: [cdt-dev] Unlink Disassembly View
> >
> >
> >
> > Toni is the custodian of the disassembly view (both at Wind
> River and in
> > CDT) so he can correct me here when he comes online (in Salzburg).
> >
> > On 09/29/2010 09:50 AM, Chuong, Patrick wrote:
> >
> > Hi Pawel,
> >
> >
> >
> > I haven't had a chance to look at the disassembly editor
> and I am wondering
> > how the editor handles some of these scenarios:
> >
> > What does the editor show when there is no source info?
> Does it simply show
> > the entire address range where the user can scroll around
> and jump to
> > different location?
> >
> > Yes.
> >
> > Are source lines and disassembly instructions interleave
> the way the DSF
> > disassembly view show or disassembly instructions are
> inserted in the order
> > of the source lines within a source a file?
> >
> > Source lines are interwoven into the memory addresses.
> >
> > I assume that if you enter disassembly mode in the editor
> for a source file,
> > the editor became readonly. Is this correct?
> >
> > The disassembly editor is separate from the regular source
> editor and it
> > doesn't behave quite the same way. The input object into
> the editor is a
> > stack frame context. From this context it retrieves source file
> > information, performs source lookup, and retrieves the disassembled
> > instructions. Just as the disassembly view does now.
> >
> > If multiple disassembly editors are open, is it possible to
> have the editors
> > to handle the two use cases I ask in my original email?
> >
> > The implementation we have in Wind River would not satisfy
> your use case.
> > We use a flavor of the pin and clone scheme to manage
> multiple instances of
> > the disassembly editor. Without a pin and clone scheme in
> place, I think a
> > good approach would open a separate editor instance for
> each address space
> > context. Then each disassembly editor would react to the
> active debug
> > context and position itself to show the PC, just as the
> editor shows the PC
> > source line in reaction to the active debug context.
> >
> > Cheers,
> > Pawel
> >
> >
> >
> >
> >
> > I see the values of having a disassembly editor that insert
> disassembly
> > instructions under source lines, as well as having a
> disassembly view to be
> > able to display instructions for the entire address ranges.
> These are two
> > different use cases and it depends on the application the
> user is dealing
> > with, I don't have strong opinion whether an editor is
> better than a view or
> > a view is better that an editor. But if the editor have all
> the features of
> > the view, than I would use the editor, because editor
> provides better source
> > and disassembly interleave.
> >
> >
> >
> > Regards,
> > Patrick
> >
> >
> >
> > ________________________________
> >
> > From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On
> > Behalf Of Pawel Piech
> > Sent: Wednesday, September 29, 2010 11:19 AM
> > To: CDT General developers list.
> > Subject: Re: [cdt-dev] Unlink Disassembly View
> >
> >
> >
> > IMO a better approach would be to present the disassembly
> content in an
> > editor. It's easier to manage multiple instances of
> editors than views and
> > it's a more natural place for disassembly anyway. This is
> what Wind River
> > does in our product and in CDT you may be able to leverage
> Mikhail's work
> > from a few years ago to make it happen.
> >
> > Cheers,
> > Pawel
> >
> > On 09/29/2010 07:59 AM, Chuong, Patrick wrote:
> >
> > Hi,
> >
> >
> >
> > I would like to know whether it is possible to unlink the
> Disassembly view
> > from the Debug view. AFAIK, the Disassembly view follows
> the selection of
> > the Debug view. If unlink is current not supported, can
> this be added?
> >
> >
> >
> > If unlink can be done or will be support in the future, can
> the Disassembly
> > also have an option to re-evaluate the expression when the target is
> > suspended?
> >
> >
> >
> > Thanks,
> > Patrick
> >
> >
> >
> >
> >
> > _______________________________________________
> >
> > cdt-dev mailing list
> >
> > cdt-dev@xxxxxxxxxxx
> >
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > _______________________________________________
> >
> > cdt-dev mailing list
> >
> > cdt-dev@xxxxxxxxxxx
> >
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> >
> >
> >
> >
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> >
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> >
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev
