Thanks a lot Ken!
The patch takes care of my main problems.
The only thing I noticed is that when I perform instruction step,
the editor’s title and content (“No source …” message) didn’t
update to reflect the new PC.
Later when I switched between different debug contexts the title
and content was picked up properly.
I don’t know if this is done for performance reason?
If I comment the check for equal editor inputs
…
if (!
input.equals(re.getEditorInput()))
…
I’ve got the desired behavior.
Somehow calling setInput with exactly the same object triggers
update of the editor.
Regards
Dobrin
From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf
Of ken.ryall@xxxxxxxxx
Sent: Friday, September 17, 2010 5:41 PM
To: cdt-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] multiple editors are opened during instruction
stepping
Dobrin,
I marked 32311 a duplicate of 314350, attached a patch to 314350, committed to
HEAD, and asked Marc to review. Please try it out and validate it if you can.
Thanks - Ken
From:
"ext
Alexiev, Dobrin" <dalexiev@xxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Mon, 13 Sep 2010 22:03:01 +0200
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] multiple editors are opened during instruction
stepping
Thanks Ken.
Looking forward for the new patch in 322311.
Dobrin
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of ken.ryall@xxxxxxxxx
Sent: Monday, September 13, 2010 3:43 PM
To: cdt-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] multiple editors are opened during instruction
stepping
Dobrin,
You are seeing multiple “Source Not Found” editors because I made a
mistake when I hooked up the editor. I have a fix that I will apply shortly.
The work in bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=322311
was done to address this issue but I was able to resolve the problem a
different way. I will be updating that bug with a new description and patch.
- Ken
From: "ext Alexiev, Dobrin" <dalexiev@xxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Mon, 13 Sep 2010 21:04:46 +0200
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: [cdt-dev] multiple editors are opened during instruction
stepping
Hello,
I noticed that if I debug with GDB-DSF, every time I select a stack frame with
no source file info a new pseudo editor opens with a title the start address of
the stack frame.
I like the presence of the button “View Disassembly…”
but I don’t understand why multiple editor has to be open with just
this purpose?
Does it make sense to reuse the editor and just change the editor’s title
and message to the new address (or function) if there is no source file
information for the stack frame.
I don’t mind seeing the address of the last selected stack frame with no
source info, I think we just have to reuse the pseudo editor (at least in the
cases that there is no source info).
Is this the same issue Bug 322311 <https://bugs.eclipse.org/bugs/show_bug.cgi?id=322311>
is trying to address?
Thanks
Dobrin
