Re: [cdt-dev] LR Parser update for RC4 candidate

[Doug Schaefer <cdtdoug@xxxxxxxxx>]

Thanks, Chris. 7.0.1 is a perfect vehicle for this change.

It sounds like the desire of the bulk of the active committers is to improve our quality processes. Ramp down has always been important. But we can only be successful if we all buy into that. Which is why this request and other questionable commits during the ramp down have me concerned. This will be a great topic for the summit.

Doug.

On Sat, Jun 5, 2010 at 3:32 PM, Chris Recoskie <recoskie@xxxxxxxxxx> wrote:

I posted this to bugzilla but will post it here as well...

While I wasn't involved in the creation or posting of this patch, and I'm not trying to argue against the veto, I do wish to point out that because the parser is generated, a small amount of changes to the grammar can result in megs of changes to the generated files. If you look at the patches, most of the changes are in generated code, especially the parser action tables, which are always huge.

There's only about a page of changes to the grammar. So the "real" size of the patch is not nearly so large as it is perceived to be.

Anyway... This should probably be material for 7.0.1 at this point.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

Doug Schaefer ---06/04/2010 05:40:57 PM----1. I can't think of anything constructive to say, so I won't. This request should have never been c

From:	Doug Schaefer <cdtdoug@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	06/04/2010 05:40 PM
Subject:	Re: [cdt-dev] LR Parser update for RC4 candidate
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

---

-1. I can't think of anything constructive to say, so I won't. This request should have never been considered let alone made.

On Fri, Jun 4, 2010 at 4:44 PM, John S Liu <jwsliu@xxxxxxxxxx> wrote:

Hi, Alena:

I just uploaded to patch to the bug page.




Thanks,

John

----------------------------------------------------------------------
John Liu, Software Developer - RDp C/C++, Eclipse CDT/RDT

IBM Canada Ltd.
8200 Warden Ave. Markham, Ontario, L6G 1C7
Internal mail: D3/201/8200 /MKM (D2-337)
Tel: (905) 413 2132


Alena Laskavaia ---06/04/2010 03:54:01 PM---Where is the patch?


From:	Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	06/04/2010 03:54 PM
Subject:	Re: [cdt-dev] LR Parser update for RC4 candidate
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

---





Where is the patch?

On Fri, Jun 4, 2010 at 3:50 PM, John S Liu <jwsliu@xxxxxxxxxx> wrote:
> Hello:
>
> We would like to add the patch to this bug into RC4 candidate,
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=315826
>
> Basically it will just update the LR parser for template arguments rules,
>
> Does anyone have any concern regarding this update?
>
>
> Thanks,
>
> John
>
> ----------------------------------------------------------------------
> John Liu, Software Developer - RDp C/C++, Eclipse CDT/RDT
>
> IBM Canada Ltd.
> 8200 Warden Ave. Markham, Ontario, L6G 1C7
> Internal mail: D3/201/8200 /MKM (D2-337)
> Tel: (905) 413 2132
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev



_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev