[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] CDT 7.0 RC4 Candidate Available
|
I can't argue with that. Having something like Gerrit would ease the pain of doing the review. It is certainly one of the draws the make me hunger for git.
On Fri, Jun 4, 2010 at 3:00 PM, John Cortell
<rat042@xxxxxxxxxxxxx> wrote:
We probably should at all stages, IMO. Quality over quantity. The high level of scrutiny in the DSF and DSF-GDB plugins has produced high quality, highly-understandable code, and I have no doubt we are getting things done right the first time more often because of it. I keep hearing about parts of CDT that are very hard to decipher and maintain. That sort of situation can only come about because developers commit features and enhancements without any critical oversight. I for one would like to hear people diving into our codebase rave about how great it is. I'm always impressed when I look at platform code. It's clean, it's well thought out, and it's well documented. That's no surprise; every change is carefully reviewed. I don't known why we're not holding ourselves to the same standards.
John
At 01:34 PM 6/4/2010, Doug Schaefer wrote:
People on the commercial side of my life have been asking about whether we do code reviews and such. We probably should, at least at this stage of the cycle.
