Re: [cdt-dev] CDT 7.0 RC4 Candidate Available

[James Blackburn <jamesblackburn@xxxxxxxxx>]

On 4 June 2010 19:34, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
> BTW, I reviewed and approved Vivian's change.
> People on the commercial side of my life have been asking about whether we
> do code reviews and such. We probably should, at least at this stage of the
> cycle.

We do tend to review patches when there's more than one developer
interested in a feature / area. But I think this is a relatively
recent phenomena in CDT.

The egit guys are using gerrit and just clicking around their gerrit
instance it looks really really cool. The ability to comment in line
on patches would make the process of reviewing could be a killer
feature IMHO:
http://egit.eclipse.org/

Cheers,
James

> Cheers,
> Doug
>
> On Fri, Jun 4, 2010 at 2:29 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
>>
>> Actually, no, I take that back. I don't want to be changing the build
>> scripts at this point. So let's keep the 14'th.
>>
>> On Fri, Jun 4, 2010 at 2:28 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
>>>
>>> BTW, the last possible respin is July 14, so that's why I selected that
>>> as the branch date.
>>> I'll ask again, do we want to branch earlier than that?
>>>
>>> On Fri, Jun 4, 2010 at 2:26 PM, Alena Laskavaia
>>> <elaskavaia.cdt@xxxxxxxxx> wrote:
>>>>
>>>> If CDT tests are part of CDT deployment then it is matter.
>>>>
>>>> On Fri, Jun 4, 2010 at 2:21 PM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>
>>>> wrote:
>>>> > That commit was mine for our test plugins.
>>>> > I assumed those don't matter for the Helios build.
>>>> >
>>>> >> -----Original Message-----
>>>> >> From: cdt-dev-bounces@xxxxxxxxxxx
>>>> >> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of John Cortell
>>>> >> Sent: Friday, June 04, 2010 2:15 PM
>>>> >> To: elaskavaia.cdt@xxxxxxxxx; CDT General developers list.;
>>>> >> CDT General developers list.
>>>> >> Subject: Re: [cdt-dev] CDT 7.0 RC4 Candidate Available
>>>> >>
>>>> >> I would hope no one is committing to HEAD at this point unless it's a
>>>> >> change he/she wants to get into Helios. I think it's unlikely that
>>>> >> this morning's build will be the last one.
>>>> >>
>>>> >> John
>>>> >>
>>>> >> At 01:13 PM 6/4/2010, Alena Laskavaia wrote:
>>>> >> >We should have branched then. There was a commit after 11:40 so if
>>>> >> > we
>>>> >> >pretend this is last build
>>>> >> >the code in the build would be different than code at the branch
>>>> >> >start. It may not matter if we tag it but
>>>> >> >it is better to have "GA" build code match with branch "beginning"
>>>> >> >
>>>> >> >On Fri, Jun 4, 2010 at 2:01 PM, Doug Schaefer
>>>> >> <cdtdoug@xxxxxxxxx> wrote:
>>>> >> > > The build is now
>>>> >> > > ready:
>>>> >> >
>>>> >> http://download.eclipse.org/tools/cdt/builds/7.0.0/I.I20100604
>>>> >> 1141/index.html
>>>> >> > > As a reminder, we officially have until the end of Monday
>>>> >> to post our bits
>>>> >> > > up to the Helios site. We can respin on our own until around
>>>> >> > Wednesday. Then
>>>> >> > > it gets complicated.
>>>> >> > > BTW from here on in, we're respin only. There is a
>>>> >> "Final" build listed on
>>>> >> > > the Helios schedule, but that'll just be the last respin
>>>> >> when and if
>>>> >> > > necessary.
>>>> >> > > (Vivian, please turn off the weekly cdtbuild for now, thanks!)
>>>> >> > > Cheers!
>>>> >> > > Doug
>>>> >> > > _______________________________________________
>>>> >> > > cdt-dev mailing list
>>>> >> > > cdt-dev@xxxxxxxxxxx
>>>> >> > > https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>> >> > >
>>>> >> > >
>>>> >> >_______________________________________________
>>>> >> >cdt-dev mailing list
>>>> >> >cdt-dev@xxxxxxxxxxx
>>>> >> >https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>> >>
>>>> >>
>>>> >> _______________________________________________
>>>> >> cdt-dev mailing list
>>>> >> cdt-dev@xxxxxxxxxxx
>>>> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>> >>
>>>> _______________________________________________
>>>> cdt-dev mailing list
>>>> cdt-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>
>>
>
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>