Re: [cdt-dev] commit auto comment in bugzilla

[Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>]

That is good idea to add commit comment there...
So I am changing [!] to [*]

Also committers this is remainer that bug comment should look like
Bug 12345
in the BEGGING of commit comment. Capitalization matters too.

So these are not valid comments !!! (ignoring the star *):

* BUG 314055 - Updated build files to add EDC docs manual to CDT build
* further changes for  Bug 291815 - fix test failure on UNIX/Linux
* Bugzilla 12345
* bug 12345
* [12345]


On Thu, May 27, 2010 at 9:51 AM, Andrew Gvozdev <angvoz.dev@xxxxxxxxx> wrote:
> I'd like to see a star for changed files [*] and actual commit message in
> the beginning of comment.
>
> Andrew
>
> On Thu, May 27, 2010 at 9:31 AM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
> wrote:
>>
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=309126
>> How is that?
>> (Same file appear more than one because you did few check-ins of it I
>> think)
>>
>> On Thu, May 27, 2010 at 8:09 AM, John Cortell <rat042@xxxxxxxxxxxxx>
>> wrote:
>> > But even with DSF, often there are additional tweaks that happen after
>> > the
>> > major fix and we sometimes don't bother creating a patch file for them.
>> > A
>> > big +1 from me on this one. It adds clutter to the bug reports, but the
>> > cross-referencing benefits far outweigh the eyesore, IMO. And it removes
>> > the
>> > human elements from the process (oversight, laziness, errors). Not to
>> > mention, it shows what was actually committed, rather than what someone
>> > intends to commit, so it is much more reliable. Patches would still be
>> > necessary for commits that require code reviews.
>> >
>> > What would really help cut down the clutter is if the content was listed
>> > as
>> > follows:
>> >
>> > *** cdt cvs genie ***
>> >
>> > [ ] PerProjectSICollector.java, 1.25
>> > [+] EFSExtensionManager.java, 1.1
>> > [-] FileSystemUtilityManager.java
>> > [ ] ErrorParserManager.java, 1.65
>> >
>> > * Only one [cdt cvs genie] header
>> > * Have a marker indicate the nature of the delta: changed, new, deleted
>> > * Show only the simple file name
>> > * Show the revision
>> > * The file names would be links. You could see the full URL by hovering,
>> > and
>> > go to the diff by clicking it.
>> >
>> > That would make this mechanism perfect in my eyes, but I think it's
>> > worth
>> > having as-is.
>> >
>> > John
>> >
>> > At 06:38 AM 5/27/2010, Alena Laskavaia wrote:
>> >
>> > If you want I can exclude you from the list (i.e if you made change it
>> > won't do it)
>> > Maybe in dsf it is normal to attach a patch but in other projects it
>> > is only done on occasion.
>> >
>> > On Thu, May 27, 2010 at 3:43 AM, Schorn, Markus
>> > <Markus.Schorn@xxxxxxxxxxxxx> wrote:
>> >> I don't like them, a patch attached to a bug is much more useful.
>> >> Markus.
>> >>
>> >>> -----Original Message-----
>> >>> From: cdt-dev-bounces@xxxxxxxxxxx
>> >>> [ mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Alena Laskavaia
>> >>> Sent: Wednesday, May 26, 2010 8:55 PM
>> >>> To: CDT General developers list.
>> >>> Subject: [cdt-dev] commit auto comment in bugzilla
>> >>> Importance: Low
>> >>>
>> >>> I finished my script that adds comments to bugzilla when
>> >>> commit performed.
>> >>> See example https://bugs.eclipse.org/bugs/show_bug.cgi?id=291815
>> >>> If you like what it does I will run it in daemon mode.
>> >>> _______________________________________________
>> >>> cdt-dev mailing list
>> >>> cdt-dev@xxxxxxxxxxx
>> >>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >>>
>> >> _______________________________________________
>> >> cdt-dev mailing list
>> >> cdt-dev@xxxxxxxxxxx
>> >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> >>
>> > _______________________________________________
>> > cdt-dev mailing list
>> > cdt-dev@xxxxxxxxxxx
>> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>