Re: [cdt-dev] build console - review patch?

[James Blackburn <jamesblackburn@xxxxxxxxx>]

I'll aim to have a look this weekend, though perhaps Andrew and Dmitry
should too...

>From Christian's comments for patch 3:
"My previous patch's popping up of a simple file selection dialog for non-C/C++
projects is discontinued.  Now, if a build console log file setting presenter
is not available for the selected project, the "Save to File" button is
disabled.  Presumably, the project's builder won't be using the
BuildOutputLogger in this case, so it seems best to disable the button."

Adding an extension point for this seems a bit like overkill,
especially if the new save button won't work by default.  It would
seem to me that patch 2 would be better, as it would allow existing
users to take advantage of the new feature without needing to write
more code.

By some poor alignment of the stars the eclipse firewall (it looks
like) has been blocking access from my corporate IP all today,
hopefully the webmasters can figure out what's up.

Cheers,
James

On 26 March 2010 12:39, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx> wrote:
> Can somebody who is familiar with build console please review the path for
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=306945
> Build Console no longer shows for non-C/C++ Projects
>
> (that was recently broken and I think it is used not only by us (i.e. qnx)
> but other cdt-based project)
> I can commit it, but I prefer somebody else reviewing it.
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>