RE: [cdt-dev] AW: [cdt-patch] Patch proposal for bugzilla 154854-gdbcons

["Mikhail Khodjaiants" <Mikhail.Khodjaiants@xxxxxxx>]

Davide,

See the "Receiving contribution" part
http://www.eclipse.org/legal/committerguidelines.php. The problem is
what to call a "significant" contribution. There was a time when any
contribution with the number of lines > 100 was counted as
"significant". If this requirement has been removed Norbert can commit
your code without going through the process.

Regards,
Mikhail  

-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Davide DENARO
Sent: 25 August 2006 08:14
To: cdt-dev@xxxxxxxxxxx
Subject: FW: [cdt-dev] AW: [cdt-patch] Patch proposal for bugzilla
154854-gdbconsoleenhancements

Hi Mikhail,

Could you give me some informations about the legal issues raised from
this type of contribution ?
How can i solve this kind of problems ?

thanks,
Davide

> -----Original Message-----
> From: Mikhail Khodjaiants [mailto:Mikhail.Khodjaiants@xxxxxxx]
> Sent: Thursday, August 24, 2006 10:46 AM
> To: CDT General developers list.
> Subject: RE: [cdt-dev] AW: [cdt-patch] Patch proposal for bugzilla
> 154854 -gdbconsoleenhancements
> 
> Davide and Norbert,
> 
> I think it is better to create two separate patches, one for each 
> feature. And I am pretty sure that there is a request to the Eclipse 
> platform to support "Save In File". There may be some legal issues 
> too. The patch is not very small, you may need a legal approval for 
> it.
> 
> Cheers,
> Mikhail Khodjaiants
> ARM Ltd.
> 
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Ploett, Norbert
> Sent: 24 August 2006 09:34
> To: CDT General developers list.
> Cc: CDT patches and commits are posted to this list.
> Subject: [cdt-dev] AW: [cdt-patch] Patch proposal for bugzilla 154854
> - gdbconsoleenhancements
> 
> David,
> 
> thank you for your patch and bugzilla documentation. Looks quite good 
> already. I have a few issues I would like to discuss before applying 
> the
> patch:
> 
> 1) I found the saving procedure a little cumbersome:
> 
>    - A dialog with a text field
>    - then the actual file browser
>    - confirm again with OK
>    - and another confirmation that the file was saved OK
> 
> I suggest to just open the file browser and have no further 
> confirmations. That OK for you?
> 
> 2) You are contrituting an icon verbose_co_mode.gif while an optically

> identical icon verbose_mode_co.gif is already there. Can you just use 
> the existing icon?
> 
> 3) After your enhancement there are two ways to change the verbose
> mode: Through the console's toggle button you are supplying or through

> the context menu of the gdb process. Now when your button is clicked 
> the new verbose state is reflected in the context menu entry, but not 
> vice
> versa: When the verbose state is changed via the context menu then 
> your toggle button does not change state and displays the wrong state.
> 
> Now I do not think that this is very grave and on the other hand it 
> may be quite a lot of fuss to change this. But I would like to hear 
> ideas on how this can be improved before doing a commit.
> 
> Thank you
> 
> 
> Norbert Ploett
> 
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 
> -- IMPORTANT NOTICE: The contents of this email and any attachments 
> are confidential and may also be privileged. If you are not the 
> intended recipient, please notify the sender immediately and do not 
> disclose the contents to any other person, use it for any purpose, or 
> store or copy the information in any medium.  Thank you.
> 
> 



_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev