RE: [cdt-dev] CVS HEAD appears to be broken for org.eclipse.cdt.ui

["Mikhail Khodjaiants" <Mikhail.Khodjaiants@xxxxxxx>]

Hi Markus,

 

I have no problem with it. I just thought that it would cleaner to have it separated. What if somebody decides to ship a product based on CDT with a different refactoring?

 

Regards,

Mikhail

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Schorn, Markus
Sent: 23 August 2006 10:03
To: CDT General developers list.
Subject: RE: [cdt-dev] CVS HEAD appears to be broken for org.eclipse.cdt.ui

Hi Mikhail,

yes it is possible and it has been that way as long it was uncertain whether the new rename refactoring would be adopted or not. There was even a fallback to the old rename refactoring

when the refactoring plugin was not present.

As things are today, the old rename refactoring has gone. I have changed the way the menu

is integrated into CView/Editor/Toolbar. It was done by an object contribution before, now it

is done the more standard way via an ActionGroup. The most important benefits of that are:

- the order in which actions appear in the context menu can precisely be defined.

- adding another refactoring action is simple.

Markus.

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Mikhail Khodjaiants
Sent: Mittwoch, 23. August 2006 10:07
To: CDT General developers list.
Subject: RE: [cdt-dev] CVS HEAD appears to be broken for org.eclipse.cdt.ui

Hi Toni,

I had had the same problem because I didn't have the refactoring plugins installed in my workspace. But is it necessary to make the cdt.ui dependent on the refactoring functionality. I haven't had a chance to look at the code, but couldn't it be done via contributions?

Thank you,

Mikhail Khodjaiants

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Leherbauer, Anton
Sent: 23 August 2006 08:23
To: CDT General developers list.
Subject: RE: [cdt-dev] CVS HEAD appears to be broken for org.eclipse.cdt.ui

Hi Norbert,

you need to update org.eclipse.cdt.refactoring, too.

Cheers,

Toni

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Ploett, Norbert
Sent: Wednesday, August 23, 2006 9:00 AM
To: CDT General developers list.
Subject: [cdt-dev] CVS HEAD appears to be broken for org.eclipse.cdt.ui

Hi,

I got CVS HEAD for org.eclipse.cdt.ui (among others) this (European) morning there are four error messages.

==========================================

Severity and Description Path Resource Location Creation Time Id

The constructor CRefactoringActionGroup(CContentOutlinePage) is undefined org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor CContentOutlinePage.java line 309 1156316209174 1170

The constructor CRefactoringActionGroup(CEditor) is undefined org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor CEditor.java line 1102 1156316209458 1172

The constructor CRefactoringActionGroup(CHViewPart) is undefined org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/callhierarchy CHViewPart.java line 295 1156316209125 1168

The constructor CRefactoringActionGroup(CView) is undefined org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview MainActionGroup.java line 166 1156316209144 1169

==========================================

The compiler is right (as usual), I do not see the required constructor for CRefactoringActionGroup anywhere. Looks like something is missing. Can anybody help?

Greetings

Norbert

 

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.