Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-dev] [PATCH] Build properties UI alignment issue

Hi,
with CDT 3.0.2, when I go to project properties, and then select "C/C++ 
Build", and then select "Tool settings" tab, I notice that the list view with 
toolnames, and the pane with editable properties are not aligned.

Please see http://zigzag.cs.msu.su/~ghost/cs/alignment/before.png
There, the entry field "Command: g++" is positioned higher than the list view.

The attached patch fixes this problem, and results in 
http://zigzag.cs.msu.su/~ghost/cs/alignment/after.png

Note that the "Command" entry field, the "All options" text edit, and "Command 
line pattern" entry field are still not aligned on the right edge, but that's 
for later.

Thanks,
Volodya




Index: ToolsSettingsBlock.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/internal/ui/ToolsSettingsBlock.java,v
retrieving revision 1.11.2.4
diff -u -r1.11.2.4 ToolsSettingsBlock.java
--- ToolsSettingsBlock.java	17 Jan 2006 00:20:23 -0000	1.11.2.4
+++ ToolsSettingsBlock.java	2 Jun 2006 08:02:14 -0000
@@ -347,9 +347,11 @@
 	 * Add the tabs relevant to the project to edit area tab folder.
 	 */
 	protected void createEditArea(Composite parent) {
-		containerSC = new ScrolledComposite(parent, SWT.H_SCROLL | SWT.V_SCROLL);
+		Composite composite = ControlFactory.createComposite(parent, 1);
+		containerSC = new ScrolledComposite(composite, SWT.H_SCROLL | SWT.V_SCROLL);
 		containerSC.setExpandHorizontal(true);
 		containerSC.setExpandVertical(true);
+		containerSC.setLayoutData(new GridData(GridData.FILL_BOTH));
 		
 		// Add a container for the build settings page
 		settingsPageContainer = new Composite(containerSC, SWT.NULL);

Back to the top