RE: [cdt-dev] Binary Search Thread

[Thomas Fletcher <ThomasF@xxxxxxx>]

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Pete MacLiesh
> Sent: October 23, 2005 1:07 AM
> To: 'CDT General developers list.'
> Subject: RE: [cdt-dev] Binary Search Thread
> 
> 
> Does the binary search thread also do the scanning for 
> archives? I discovered an "interesting" bit of code in the 
> archive scanner that does a readline on any file it finds to 
> see if it's an archive. Well, I had a project with multiple 
> 20MB binary files in it which happened to not have any eol 
> chars. that readline went on for a long long long time before 
> it figured out it was not an archive anyway. I forget what 
> thread called it, but it was one of the workspace change listeners.
> 
> Conservative fix is trivial ... if you like I'll bugzilla it 
> and attach a patch (though it might be 74387?). It could also 
> be made much faster (for big projects) by only bothering to 
> open defined archive extensions. Right now IIRC it seems to 
> open and check anything that comes up on the delta list.

Sounds like it may be part of a left-over artifact from days when
we didn't have a well defined set of filtering extensions.

Please ... file a PR and attach your patch/diff.  Simple changes
like this go a long way in helping performance and stability.

Thanks, 
 Thomas