[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [cdt-dev] RE: [cdt-debug-dev] Bring Back "Add Watchpoint (C/C++)" for CDT 2.1.1?
|
> Lets follow up with a PR, asap. 2.1.1 is approaching end-game.
See bug 84165. (https://bugs.eclipse.org/bugs/show_bug.cgi?id=84165)
--
Daryl
-----Original Message-----
From: cdt-debug-dev-admin@xxxxxxxxxxx
[mailto:cdt-debug-dev-admin@xxxxxxxxxxx] On Behalf Of Alain Magloire
Sent: Tuesday, February 01, 2005 08:48
To: cdt-dev@xxxxxxxxxxx
Cc: cdt-debug-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] RE: [cdt-debug-dev] Bring Back "Add Watchpoint
(C/C++)" for CDT 2.1.1?
>
> Alain,
>
Bonjour,
> > User enter "0x800fa4" in the text field ...
> > (gdb) watch 0x800fa4 <----- REALLY BAD
> > (gdb) watch *0x800fa4 <----- GOOD
> >
> > Note: To make this more clear, maybe this action should be name "Add
> > Watch Expression"
> > Or we could do some basic sanity check on the expression, if an
> > integer value, do the right
> > thing in gdb/mi.
>
> That sounds good to me. Could we squeeze that sanity check into CDT
> 2.1.1?
>
We did not hear/see any objections/-1 to this.
It seems folks do not have any strong opinions against.
So the next step would be to make a PR, with the TargetMilestone 2.1.1
Mikhailk seems to say the resucrecting the code should have low impact.
> > If the selection is on a global variable ... we are good to go, if
> > it is on a local variable ... we could go from warning the user to
> > implementing more complex scenarios ...
> >
> > in this satisfactory or you still would like to have a liberal
> > "add Watch expression" that the user could enter any expression ?
>
> So you're suggesting that we remove the "Add Watch Expression" action
This is my mistake, it should be "Add Watchpoint ...", the label "Add
Watch Expression"
was already use for the Expression view. Sorry for the confustion.
> (added in CDT 2.1.1) from CDT 3.0, and introduce watchpoints on local
> variables (first with a warning that they essentially only work until
> out of scope--maybe with some indication in the Breakpoint view for
> watchpoints on locals out of scope--and later re-setting the
watchpoint
> when we detect that we're within scope)?
Yes something like that, although the idea that was put forward to
detect
the reentering of the scope was to put a temporary breakpoint.
> I shouldn't speak for our
> customers (so I'll ask our product planning team to do that), but this
> sounds good to me. I don't think our customers will miss the
> expressions, especially since they'll still be able to get at them
> through the GDB console.
>
Yes, that was the reason to take this out in the first place.
> Is there someone out there who is able to reintroduce this "Add Watch
> Expression" into CDT 2.1.1? If not I'm willing, though I'll have a
bit
> of a learning curve to climb. (So it might take me longer.)
>
Lets follow up with a PR, asap. 2.1.1 is approaching end-game.
_______________________________________________
cdt-debug-dev mailing list
cdt-debug-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
