Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] About implementation of IScannerInfoProvider

> 
> I think that current implementation of CProjectWizard.doRun() should be
> changed.
> 
> protected void doRun(IProgressMonitor monitor) throws CoreException {
> 
> createNewProject(monitor);
> 
> // Associate the project with the standard builder so the clients can get
> proper information
> 
> try {
> 
> ICDescriptor desc =
> CCorePlugin.getDefault().getCProjectDescription(newProject);
> 
> desc.remove(CCorePlugin.BUILD_SCANNER_INFO_UNIQ_ID);
> 
> desc.create(CCorePlugin.BUILD_SCANNER_INFO_UNIQ_ID,
> StandardBuildManager.INTERFACE_IDENTITY);
> 
> } catch (CoreException e) {
> 
> // TODO Flag the error to the user
> 
> }
> 
> The explicit assignment of ISCannerInfoProvider implementation for the
> standard builder replaces all the settings that were done while
> createNewProject was executed. It is not good if I use ICOwner.config()
> method for that (I think this is a natural place for a builder
> configuration).
> 
> 

Yes, I agree.  It does not belong in this class it should be in
the appropiate Wizard.  In this case the StandardBuildManager wizard.

Lets create a PR, to fix this.
> 
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-dev
> 


-- 
au revoir, alain
----
Aussi haut que l'on soit assis, on est toujours assis que sur son cul !!!



Back to the top