[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [cdt-debug-dev] Hardware breakpoint support in CDT
|
I have attached a patch to the bug.
(https://bugs.eclipse.org/bugs/attachment.cgi?id=95964)
Can you please check?
Thanks,
Jiju
-----Original Message-----
From: cdt-debug-dev-bounces@xxxxxxxxxxx
[mailto:cdt-debug-dev-bounces@xxxxxxxxxxx] On Behalf Of Elena Laskavaia
Sent: 14 April 2008 17:25
To: CDT Debug developers list
Subject: Re: [cdt-debug-dev] Hardware breakpoint support in CDT
Yes please create another patch for 118100
Jiju George T wrote:
>
> Yes. That is the best way I can think now of making the hardware
> breakpoint
> support in CDI useful. Shall I create a patch for this to the same bug
> for
> your review?
>
> -----Original Message-----
> From: cdt-debug-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-debug-dev-bounces@xxxxxxxxxxx] On Behalf Of Elena Laskavaia
> Sent: 14 April 2008 17:06
> To: CDT Debug developers list
> Subject: Re: [cdt-debug-dev] Hardware breakpoint support in CDT
>
> So how about we just add small patch that introduces _
> ICBreakpoint._/_HARDWARE_/
> attribute and CDI change that takes this into account, without modifying
> all breakpoint creation functions?
>
> Jiju George T wrote:
> >
> >
> >
> > I am not much worried about the UI patch since I can add my own ruler
> > actions according to our product requirement without needing any
> > modifications in the cdt debug ui plugins. But the real issue I am
> > having is with the CDT CDI model.
> >
> >
> >
> > I have defined a new breakpoint type, a new marker and also added a
> > new attribute to the marker say HARDWARE. I have added this new
> > attribute also to the attribute map of CLineBreakpoint as shown below
> >
> >
> >
> > _HashMap_ attributes = *new* _HashMap_( 10 );
> >
> > _attributes.put( IBreakpoint._/_ID_/_,
> > /getPluginIdentifier/() )_;
> >
> > _attributes.put( IMarker._/_LINE_NUMBER_/_, _*_new_*_
> > Integer( lineNumber ) )_;
> >
> > _attributes.put( IBreakpoint._/_ENABLED_/_,
> > Boolean./valueOf/( enabled ) )_;
> >
> > _attributes.put( ICBreakpoint._/_IGNORE_COUNT_/_,
> > _*_new_*_ Integer( ignoreCount ) )_;
> >
> > _attributes.put( ICBreakpoint._/_CONDITION_/_, condition
> )_;
> >
> > _attributes.put( ICBreakpoint._/_SOURCE_HANDLE_/_,
> > sourceHandle )_;
> >
> > _attributes.put(
> > ICBreakpoint._/_HARDWARE_/_,ICBreakpoint._/_HARDWARE_/_, true )_;
> >
> >
> >
> > *new* CHWLineBreakpoint( resource, attributes, register );
> >
> >
> >
> > But when CBreakpointManager processes this CLineBreakpoint, it always
> > call cdiTarget.setLineBreakpoint() passing type as
> > ICDIBreakpoint.REGULAR. It never passes on ICDIBreakpoint.HARWARE type
> > to CDI target. Due to this limitation of CBreakpointManager, hardware
> > breakpoint support in the CDI model is really not usable. If we can
> > apply the CDI model patch then at least the hardware breakpoint
> > feature in CDI model becomes useful.
> >
> >
> >
> > Regards,
> >
> > Jiju
> >
> >
> >
> >
> >
> > -----Original Message-----
> > From: cdt-debug-dev-bounces@xxxxxxxxxxx
> > [mailto:cdt-debug-dev-bounces@xxxxxxxxxxx] On Behalf Of Elena Laskavaia
> > Sent: 14 April 2008 15:18
> > To: CDT Debug developers list
> > Subject: Re: [cdt-debug-dev] Hardware breakpoint support in CDT
> >
> >
> >
> > I think this is too specific to change in general UI.
> >
> > You can use breakpoint extension mechanism to add more attributes, such
> >
> > as hardware breakpoint flag.
> >
> > To create them you have to create your own UI because current ui
> >
> > mechanism, such as double click on source like does not allow to change
> >
> > attributes. To change this property you contribute property page, from
> >
> > there you can implement a call that would re-set breakpoint from
> >
> > software to hardware.
> >
> >
> >
> >
> >
> > Jiju George T. wrote:
> >
> > >
> >
> > > Hi All,
> >
> > >
> >
> > > We are developing an embedded debugger based on Eclipse and CDT. I
> >
> > > am trying to add hardware breakpoints support. When I checked CDT CDI
> >
> > > model, I could see that ICDIBreakpoint interface already supports
> >
> > > hardware breakpoints. But CDT core classes like CBreakpoint ,
> >
> > > CBreakpointManager , CDIDebugModel etc and UI does not provide any
> >
> > > mechanism to create an ICDIBreakpoint of type
> ICDIBreakpoint.HARDWARE.
> >
> > >
> >
> > > When I searched CDT news groups and bugzilla, I came across below
> >
> > > enhancement request to add hardware breakpoint support to CDT CDI
> >
> > > model and UI.
> >
> > >
> >
> > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=118100
> >
> > >
> >
> > > Patches to add hardware breakpoint support in UI and model are
> >
> > > available in the above. Any idea on why this enhancement is on hold?
> >
> > > Is it because decision on a better UI for adding Toggle Hardware
> >
> > > breakpoints has not yet taken? If so then is there any possibility of
> >
> > > committing the CDI model related changes and leaving UI decision to
> >
> > > users? This will allow vendors to decide on the UI for hardware
> >
> > > breakpoint and use CDT plugins without applying any local patches for
> >
> > > adding hardware breakpoint support to CDI model.
> >
> > >
> >
> > > Thanks,
> >
> > >
> >
> > > Jiju George
> >
> > >
> >
> > >
> >
> > >
> >
> > _______________________________________________
> >
> > cdt-debug-dev mailing list
> >
> > cdt-debug-dev@xxxxxxxxxxx
> >
> > https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
> >
> _______________________________________________
> cdt-debug-dev mailing list
> cdt-debug-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
>
>
> _______________________________________________
> cdt-debug-dev mailing list
> cdt-debug-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
>
_______________________________________________
cdt-debug-dev mailing list
cdt-debug-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
