Re: [cbi-dev] Bundles that may be improperly/incorrectly build with Tych

[Igor Fedorenko <igor@xxxxxxxxxxxxxx>]

On 12-07-17 7:47 AM, Krzysztof Daniel wrote:
> On Tue, 2012-07-17 at 06:32 -0400, Igor Fedorenko wrote:
> > I was asked to help with #2 at end of last summer and I believe we
> > made
> > major progress already.
>
> I do not negate that :-). The fact that I'm able to build Eclipse in
> less than 15 minutes from my first checkout is a big success.
>
>
> I'm worried about (from the list of files in my previous emails):
> * jdt updating binary jars accross the bundle boundaries (if it is not
> used, then I'm fine, but the code says it is used). IMO, major
> refactoring should happen here either to merge those bundles, or to
> split them to avoid circular dependencies (current case: A depends B, B
> is build first, A is built and updates B artifacts). [1]

I think this highlights the problem with custom callbacks -- it is
really hard to understand the indent for somebody not intimately
familiar with the code. CBI is closely related with Eclipse LTS effort,
where ability to quick bring new developers up to speed is rather
important and common no-surprises build approach is one aspect of making
this possible.

> * jdt compiling internal jars [2]

Using maven-compiler-plugin should not be a problem, but I we need to
understand what is the intent of this code

> * custom operations which do not really have maven counterpart, like
> indexing documentation (all bundles matching org.eclipse.*doc*).

This should be already supported, although not tested and not documented

https://bugs.eclipse.org/bugs/show_bug.cgi?id=366319


> * Unpacking and repacking sources embedded as zips [3]?

Again, we need to understand why this code was needed before we can
decide what to do about it.


--
Regards,
Igor