[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cbi-dev] Empty source bundles
- From: Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
- Date: Tue, 15 May 2012 18:47:15 -0400
- Delivered-to: email@example.com
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=aq+yJuJ9L/2lTYmijWG8HMcZzGxnbnA9jcypuebxLrA=; b=xQQv5i6aEJ83phCIILXUk2OudW6FKvbXQBIZFpPI8QJuCedRC180P91B58iY1STnX9 isuFU5pi3LAq/NgsvMJ+81fPcjUNvWuWa1sg4bC6dfpKNs+bKhTsiWpOJWcpZ+Wo+R8c Nb9H51uswDbOWCsny0XtywK/+MGUnJLUX9wqdg+8JgARjdTmfbo4qGRhsGdQ1p0Eo+ro EJpxfZSzytjFYIug7Akj7brw3TyEGlz3xuoDvmEDvl/YWtCtBt+VNdZ/Lq0CvEoYjW2R uebKTxLyVvrrYFkfSQ1WP2B6EB8KV/JH2qpPKJsBkDw/rU8B9RzEta0XEKvpIWgM2B89 EWrQ==
On Tue, May 15, 2012 at 5:01 PM, Thanh Ha <thanh.ha@xxxxxxxxxxx>
I incorrectly recalled this morning that there were ~5 .source
bundles that were removed from features. I did a grep of all the
feature.xml files and only found 2 listed below that were commented
ÂÂ igorf: org.eclipse.sdk.tests does not have any sources, afaict
ÂÂ thanh: needed to comment this out for build to succeed.
ÂÂ Not sure if this was the right thing to do.
OK, these were the ones I was looking for, I'll find out if we can just remove them upstream.
The reason for my confusion was that there was actually additional
plugins that we removed in the features.xml as well, I've listed the
ones that I could find below.
Why are these commented out?Â AFAIK CBI-Platform build is picking up these platforms from the p2-natives repo.Â Can they be included since they're coming from a pre-built repo?Â I don't believe we would want these changes pushed upstream.
I remember the bundle-shape changes.Â We were supposed to push those upstream (I thought we had already, but I guess not).Â Any build.properties changes we would have to review before we pushed them upstream.
I think we should open one bug per project (Platform, JDT, PDE, Equinox) and list the repos that they should cover.Â Then committers can pull their changes.
Hi floor.Â Make me a sammich! - GIR