Re: [cbi-dev] Empty source bundles

[Thanh Ha <thanh.ha@xxxxxxxxxxx>]

Hi Paul,

I incorrectly recalled this morning that there were ~5 .source bundles that were removed from features. I did a grep of all the feature.xml files and only found 2 listed below that were commented out.


eclipse.platform.releng/features/org.eclipse.sdk.tests/feature.xml:
<!--
   igorf: org.eclipse.sdk.tests does not have any sources, afaict
   <plugin
         id="org.eclipse.sdk.tests.source"
         download-size="0"
         install-size="0"
         version="0.0.0"/>
-->


eclipse.platform.releng/features/org.eclipse.sdk/feature.xml:
<!--
   thanh: needed to comment this out for build to succeed.
   Not sure if this was the right thing to do.
   <includes
         id="org.eclipse.cvs.source"
         version="0.0.0"/>
-->


The reason for my confusion was that there was actually additional plugins that we removed in the features.xml as well, I've listed the ones that I could find below.


eclipse.platform.releng/features/master/feature.xml:
<!--
   <includes
         id="org.eclipse.sdk.examples"
         version="0.0.0"/>
-->
<!--
   <plugin
         id="org.eclipse.swt.win32.wce_ppc.arm"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>   
-->


eclipse.platform.ui/features/org.eclipse.e4.rcp/feature.xml:
   <!--
   <plugin
         id="org.eclipse.swt.gtk.linux.s390x"
         os="linux"
         ws="gtk"
         arch="s390x"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.gtk.linux.s390"
         os="linux"
         ws="gtk"
         arch="s390"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.gtk.solaris.sparc"
         os="solaris"
         ws="gtk"
         arch="sparc"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.gtk.solaris.x86"
         os="solaris"
         ws="gtk"
         arch="x86"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.gtk.linux.ppc64"
         os="linux"
         ws="gtk"
         arch="ppc64"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>
   -->
   <!--
   <plugin
         id="org.eclipse.swt.cocoa.macosx"
         os="macosx"
         ws="cocoa"
         arch="ppc"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.cocoa.macosx"
         os="macosx"
         ws="cocoa"
         arch="x86"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>
   -->

   <!--
   <plugin
         id="org.eclipse.swt.gtk.aix.ppc"
         os="aix"
         ws="gtk"
         arch="ppc"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.gtk.aix.ppc64"
         os="aix"
         ws="gtk"
         arch="ppc64"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>

   <plugin
         id="org.eclipse.swt.gtk.hpux.ia64_32"
         os="hpux"
         ws="gtk"
         arch="ia64_32"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"
         unpack="false"/>
   -->


We did not discuss on the call but there were also numerous MANIFEST.MF files that were modified as well to add "Eclipse-BundleShape: dir". Also a few build.properties that were also modified as well.


Regards,

Thanh



On 05/15/2012 03:56 PM, Paul Webster wrote:

Thanh, could you point me at an example of the empty source bundles that have been deleted from a feature?

Thanx
PW


--
Paul Webster
Hi floor.  Make me a sammich! - GIR

_______________________________________________
cbi-dev mailing list
cbi-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/cbi-dev