Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [buckminster-dev] Hudson plugin and provisioning

Hi Johannes,

glad I could help :) And thanks for the explanations re Master/Slave issues. This was my first encounter with a piece of hudson code. Up to now I just used it.

Which Windows version does your Virtual box use? The sh problem is solved in 1.0.1, but now I'm having trouble with the director/buckminster.bat files on my WinXP32 machine.

  * Parsing the vmargs does not work. The loop in the batch file splits -Dbuckminster.output.root=D:\hudson in two seperate args, omitting the '=':

	"...\bin\java.exe"  -Dbuckminster.output.root D:\hudson ...

The same happens when I copy the original command line to a "DOS Box". If I add "" around the -D args, it works:
	"...\buckminster.bat" ... -vmargs "-Dbuckminster.output.root=D:\hudson"

    This might depend on the windows version being used, I don't know.

  * The batch files (director/buckminster) have trouble when being installed in a directory with blanks (it's them again... ;)). But there's nothing your plugin can do about that. I'll see if I can find an Eclipse bug for this or file a new one. It's this for statement that does not work if %EXE_DIR% contains blanks:

	for /f "delims= tokens=1" %%c in ('dir /B /S /OD %EXE_DIR%\plugins\org.eclipse.equinox.launcher_*.jar') do set EQUINOXJAR=%%c

    This works:

	for /f "delims= tokens=1" %%c in ('dir /B /S /OD "%EXE_DIR%\plugins\org.eclipse.equinox.launcher_*.jar"') do set EQUINOXJAR=%%c

Regards,
Daniel

Johannes Utzig wrote:
Hi Flavio,

I installed Windows on a virtual box and configured it as a hudson slave to finally have my own testing environment for that. Everything seems to work fine now on both the Linux host and the Windows slave (no cygwin installed). I've just released version 1.0.1 that contains the fixes. I hope it works better for you now. The new version will show up as usual with a few days delay in your update center.

Thank you for all the help.

Best regards,
Johannes

Hi Daniel,

I just replied to Flavio in the other thread in the buckminster newsgroup:

"I installed Windows on a virtual box and configured it as a hudson slave to finally have my own testing environment for that. Everything seems to work fine now on both the Linux host and the Windows slave (no cygwin installed). I've just released version 1.0.1 that contains the fixes. I hope it works better for you now. The new version will show up as usual with a few days delay in your update center."

Same applies to you of course, thank you very much for the patch you sent me, the absolute paths finally did the trick.
I had to change a few things though (in case you are interested):
The directorScriptName and buckyScriptName do not work like that in a distributed build (Master/Slave). The code is always executed on the master, therefore the methods would only return the correct script name if Master and Slave run the same operating system. The trick was to make this kind of invocation over a VirtualChannel to have it executed on the current Build machine. Other than that I took a similar approach like you in the patch you submitted, feel free to have a look at the code changes.

Best regards,
Johannes



Back to the top