[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [buckminster-dev] Hudson plugin and provisioning
|
Hi Johannes,
First of all, thank you very much for your effort on this.
You're welcome, I'm glad not everything was useless :)
I started setting up a development environment and "hacking around" last week and did not sync since then.
It might well be that the remaining issues have been solved in 1.0.0, I'll check.
Regards,
Daniel
Johannes Utzig wrote:
Hi Daniel,
please see comments inline.
Am 01.04.2010 06:45, schrieb Daniel Weber:
Hi again,
installation still fails under windows using 0.9.5, some files could not
be found.
Yes, Hudson has to ability to execute sh scripts on Windows machines,
so that is as expected.
Hm, I watched hud-son spawning sh.exe from where it was found in PATH,
there did not seem to be any special treatment for sh scripts. Is this
really expected to work out-ofthe-box?
I noticed that by now, my mistake, I thought they have some special
treatment because the 'execute shell script' build step allowed the user
to use unix commands even on a windows box, but it seems like it relies
on an sh.exe beeing in the path or configured in Hudson...
I grabbed the sources and tried to debug and fix the installation issues
under windows.
Find attached a patch that implements the following changes: The
installation mechanism no longer generates and runs a shell script but
spawns processes for the necessary installation steps (i.e. use the
directoy to install buckminster and then call buckminster itself to add
additional features). The only OS-specific part is now the selection of
the respective start scripts (director vs. director.bat, same for
buckminster), the rest is the same for all OSes. Because the plugin now
starts the processes directly and checks their return values, the
installation will also fail if any of the installation commands fails.
This did not work in my first try (where I created and ran a .bat file
to perform the installation).
First of all, thank you very much for your effort on this. As a matter
of fact, I went down the same road just yesterday:
http://www.eclipse.org/forums/index.php?t=msg&th=165216&start=0&;
The installation and update is no longer done with an sh script,
everything is executed as a single director invocation.
However, as you can see in the given Thread there's still a slight
problem to make it run on both Windows and Linux.
But I think this line of your patch should do the trick:
+ final String director =
directorDir.child(directorScriptName()).absolutize()
+ .getRemote();
The problem in the thread comes from relativ paths, if I go back to
absolute ones, the command line gets longer, but it should work then (if
I add the .bat extension for windows like you did).
I will make the necessary changes tonight and send Flavio another
version to test on windows.
I'll publish version 1.0.1 as soon it's confirmed that it works on
Windows, Linux and Master/Slave.
The patch has been created against SVN Revision 29269 and also includes
a small fix in EclipseBuckminsterBuilder (ran into an exception on the
configuration page).
That bug is fixed already in version 1.0.0, but thank you anyway :)
One more thing I noticed: after updating to 0.9.5, the drop down box on
the auto install configuration page is empty unless
userContent/buckminster/buckminster.json exists. A default installer
configuration seems to be missing? Or maybe something went wrong during
my update.
Is it possible that it's a few days ago that you checked? If so, it's
probably the same as here:
http://issues.hudson-ci.org/browse/HUDSON-6085
I made a change to the json file one of these days and introduced a
syntax error that prevented Hudson from parsing (and downloading) it
properly :-/
Best regards,
Johannes
