[buckminster-dev] Launcher Icon Missing

[Johannes Utzig <mail@xxxxxxxxx>]

Hi,

I am building an eclipse product with the buckminster version for 
3.5RC4. I noticed that no launcher icon gets created although it works 
with the eclipse export product wizard.

I wanted to create a patch for that, but after some investigation I'm 
really not sure which component is actually behaving wrong, so I just 
post my results so far:

Let's say my workspace consists of a feature project 'feature' with a 
.product file and a plugin project 'product' with the launcher icon and 
the product extension.

-WS
 |-product
    -icon.ico
    -plugin.xml
 |-feature
    -feature.xml
    -product.product

After debugging the P2SiteGenerator#getProductDescriptor I noticed the 
following:

It executes new ProductFile(productFile.getAbsolutePath())

The ProductFile starts parsing and retrieves the image paths. This is 
done in the addIcon method ('value' is the location entered in the 
.product file and 'location' is the absolute location of the .product file):

if(!new File(value).isAbsolute())
            value = new File(location.getParentFile(), 
value).getAbsolutePath();
list.add(value);

The path produced by the chooser dialog in the .product editor seems to 
be relative to the workspace root. In the given example that makes 
/product/icon.ico

Applying the above method will result in 
/abs/path/to/workspace/feature/product/icon.ico when it really should be 
/abs/path/to/workspace/product/icon.ico

So obviously this path is wrong and it's of no surprise that the icon is 
missing in the produced launcher. If I manually edit the path from 
/product/icon.ico to /icon.ico and copy the icon from 'product' to 
'feature' everything works fine (although the .product editor complains 
about a path pointing nowhere).

I hope that was a somewhat understandable description.

I'd open a bug, but I'm very unsure if it's the .product editor's fault, 
the ProductFile class' fault, buckminster's fault for not doing some 
secret magic the eclipse product export is doing, or my own, for a 
misshaped project layout.

Please let me know if I should open a bugzilla for that (but on which 
component?) or if can otherwise be of support.

Best regards,
Johannes