Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[buckminster-dev] Re: Subversive support

Thomas Spiessens wrote:
Hi guys,
I have finished my Buckminster plugin with Subversive support. As Thomas has asked, I have named it org.eclipse.buckminster.subversive and org.eclipse.buckminster.subversive.feature. I have used "subversive" as readerType indication in the rmap file. Is this good for you ?

Currently, the subversive and subclipse plugin both contain lots of common code. It might be a good idea to do some refactoring to squeeze out the common parts.

Maybe it's also a good idea to change the "svn" readerType in the rmap file to "subclipse" to better reflect the actual plugin being used. In this way, there would be two Subversion reader types, "subclipse" and "subversive".

That's one way of looking at it. Another way would be to call both 'svn' to avoid putting the responsibility of which to use on the author of the RMAP. I'd rather prefer that. Then the clients (IDE users) have a choice of which 'svn' reader they would like to install and they can still share the same RMAP.

Kind Regards,
Thomas Hallgren



Back to the top